summaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorPaolo Bonzini2020-09-04 14:03:42 +0200
committerThomas Huth2020-09-07 12:34:17 +0200
commitcc9962d8ea80b39118d921109fd2f8db308e1d4a (patch)
tree02df2145c9a189d874ef5900f7e37aed425d9830 /tests
parentgitlab: expand test coverage for crypto builds (diff)
downloadqemu-cc9962d8ea80b39118d921109fd2f8db308e1d4a.tar.gz
qemu-cc9962d8ea80b39118d921109fd2f8db308e1d4a.tar.xz
qemu-cc9962d8ea80b39118d921109fd2f8db308e1d4a.zip
tests/qtest: do not list ahci-test twice
This is caught by "meson test", which complains about two tests with the same name. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Message-Id: <20200904120342.11370-1-pbonzini@redhat.com> Fixes: a2ce7dbd917 ("meson: convert tests/qtest to meson") Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests')
-rw-r--r--tests/qtest/meson.build1
1 files changed, 0 insertions, 1 deletions
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index 8f8fdb1336..874b5be62b 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -49,7 +49,6 @@ qtests_i386 = \
qtests_pci + \
['fdc-test',
'ide-test',
- 'ahci-test',
'hd-geo-test',
'boot-order-test',
'bios-tables-test',
generated by cgit v1.2.3-55-g7522 (git 2.39.0) at 2026-07-30 18:37:01 +0200
ed badly in patches, causing off-by-one errors in almost every line. - It is the QEMU coding style. Do not leave whitespace dangling off the ends of lines. 2. Line width Lines are 80 characters; not longer. Rationale: - Some people like to tile their 24" screens with a 6x4 matrix of 80x24 xterms and use vi in all of them. The best way to punish them is to let them keep doing it. - Code and especially patches is much more readable if limited to a sane line length. Eighty is traditional. - It is the QEMU coding style. 3. Naming Variables are lower_case_with_underscores; easy to type and read. Structured type names are in CamelCase; harder to type but standing out. Enum type names and function type names should also be in CamelCase. Scalar type names are lower_case_with_underscores_ending_with_a_t, like the POSIX uint64_t and family. Note that this last convention contradicts POSIX and is therefore likely to be changed. When wrapping standard library functions, use the prefix qemu_ to alert readers that they are seeing a wrapped version; otherwise avoid this prefix. 4. Block structure Every indented statement is braced; even if the block contains just one statement. The opening brace is on the line that contains the control flow statement that introduces the new block; the closing brace is on the same line as the else keyword, or on a line by itself if there is no else keyword. Example: if (a == 5) { printf("a was 5.\n"); } else if (a == 6) { printf("a was 6.\n"); } else { printf("a was something else entirely.\n"); } Note that 'else if' is considered a single statement; otherwise a long if/ else if/else if/.../else sequence would need an indent for every else statement. An exception is the opening brace for a function; for reasons of tradition and clarity it comes on a line by itself: void a_function(void) { do_something(); } Rationale: a consistent (except for functions...) bracing style reduces ambiguity and avoids needless churn when lines are added or removed. Furthermore, it is the QEMU coding style. 5. Declarations Mixed declarations (interleaving statements and declarations within blocks) are generally not allowed; declarations should be at the beginning of blocks. Every now and then, an exception is made for declarations inside a #ifdef or #ifndef block: if the code looks nicer, such declarations can be placed at the top of the block even if there are statements above. On the other hand, however, it's often best to move that #ifdef/#ifndef block to a separate function altogether. 6. Conditional statements When comparing a variable for (in)equality with a constant, list the constant on the right, as in: if (a == 1) { /* Reads like: "If a equals 1" */ do_something(); } Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read. Besides, good compilers already warn users when '==' is mis-typed as '=', even when the constant is on the right.
generated by cgit v1.2.3-55-g7522 (git 2.39.0) at 2026-07-30 18:37:01 +0200