summaryrefslogtreecommitdiffstats
path: root/tools/virtiofsd
diff options
context:
space:
mode:
authorVivek Goyal2021-02-10 19:27:44 +0100
committerDr. David Alan Gilbert2021-02-16 18:54:18 +0100
commit26ec1909648e0c06ff06ebc3ddb2f88ebeeaa6a9 (patch)
tree92f1ba1b73c68d8ababa573cf26972945912fb0f /tools/virtiofsd
parentviriofsd: Add support for FUSE_HANDLE_KILLPRIV_V2 (diff)
downloadqemu-26ec1909648e0c06ff06ebc3ddb2f88ebeeaa6a9.tar.gz
qemu-26ec1909648e0c06ff06ebc3ddb2f88ebeeaa6a9.tar.xz
qemu-26ec1909648e0c06ff06ebc3ddb2f88ebeeaa6a9.zip
virtiofsd: Do not use a thread pool by default
Currently we created a thread pool (With 64 max threads per pool) for each virtqueue. We hoped that this will provide us with better scalability and performance. But in practice, we are getting better numbers in most of the cases when we don't create a thread pool at all and a single thread per virtqueue receives the request and processes it. Hence, I am proposing that we switch to no thread pool by default (equivalent of --thread-pool-size=0). This will provide out of box better performance to most of the users. In fact other users have confirmed that not using a thread pool gives them better numbers. So why not use this as default. It can be changed when somebody can fix the issues with thread pool performance. Signed-off-by: Vivek Goyal <vgoyal@redhat.com> Message-Id: <20210210182744.27324-2-vgoyal@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'tools/virtiofsd')
-rw-r--r--tools/virtiofsd/fuse_lowlevel.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c
index f78692ef66..1aa26c6333 100644
--- a/tools/virtiofsd/fuse_lowlevel.c
+++ b/tools/virtiofsd/fuse_lowlevel.c
@@ -18,7 +18,7 @@
#include <sys/file.h>
-#define THREAD_POOL_SIZE 64
+#define THREAD_POOL_SIZE 0
#define OFFSET_MAX 0x7fffffffffffffffLL