diff options
| author | Markus Armbruster | 2013-01-16 14:50:28 +0100 |
|---|---|---|
| committer | Blue Swirl | 2013-01-19 11:22:44 +0100 |
| commit | 089da572b956ef0f8f5b8d5917358e07892a77c2 (patch) | |
| tree | 3bcc9c8123e3e21e6645eaa63e97914447e9e25c /trace-events | |
| parent | pc: Clean up bochs_bios_init()'s (non-)use of sizeof (diff) | |
| download | qemu-089da572b956ef0f8f5b8d5917358e07892a77c2.tar.gz qemu-089da572b956ef0f8f5b8d5917358e07892a77c2.tar.xz qemu-089da572b956ef0f8f5b8d5917358e07892a77c2.zip | |
fw_cfg: Use void *, size_t instead of uint8_t *, uint32_t for blobs
Many callers pass size_t, which gets silently truncated to uint32_t.
Harmless, because all practical sizes are well below 4GiB. Clean it
up anyway. Size overflow now fails assertions.
Bonus: saves a whole bunch of silly casts.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Diffstat (limited to 'trace-events')
| -rw-r--r-- | trace-events | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/trace-events b/trace-events index cf76a11147..7de9106664 100644 --- a/trace-events +++ b/trace-events @@ -172,7 +172,7 @@ fw_cfg_write(void *s, uint8_t value) "%p %d" fw_cfg_select(void *s, uint16_t key, int ret) "%p key %d = %d" fw_cfg_read(void *s, uint8_t ret) "%p = %d" fw_cfg_add_file_dupe(void *s, char *name) "%p %s" -fw_cfg_add_file(void *s, int index, char *name, uint32_t len) "%p #%d: %s (%d bytes)" +fw_cfg_add_file(void *s, int index, char *name, size_t len) "%p #%d: %s (%zd bytes)" # hw/hd-geometry.c hd_geometry_lchs_guess(void *bs, int cyls, int heads, int secs) "bs %p LCHS %d %d %d" |