diff options
| author | Stefan Hajnoczi | 2017-08-21 15:55:30 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi | 2017-08-30 19:02:10 +0200 |
| commit | 3e4c705212abfe8c9882a00beb2d1466a8a53cec (patch) | |
| tree | d2d27c2119c94c3af174b0d67734b3c8c4381584 /util/oslib-posix.c | |
| parent | qemu-doc: Add UUID support in initiator name (diff) | |
| download | qemu-3e4c705212abfe8c9882a00beb2d1466a8a53cec.tar.gz qemu-3e4c705212abfe8c9882a00beb2d1466a8a53cec.tar.xz qemu-3e4c705212abfe8c9882a00beb2d1466a8a53cec.zip | |
qcow2: allocate cluster_cache/cluster_data on demand
Most qcow2 files are uncompressed so it is wasteful to allocate (32 + 1)
* cluster_size + 512 bytes upfront. Allocate s->cluster_cache and
s->cluster_data when the first read operation is performance on a
compressed cluster.
The buffers are freed in .bdrv_close(). .bdrv_open() no longer has any
code paths that can allocate these buffers, so remove the free functions
in the error code path.
This patch can result in significant memory savings when many qcow2
disks are attached or backing file chains are long:
Before 12.81% (1,023,193,088B)
After 5.36% (393,893,888B)
Reported-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Tested-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20170821135530.32344-1-stefanha@redhat.com
Cc: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'util/oslib-posix.c')
0 files changed, 0 insertions, 0 deletions