diff options
| author | Alberto Garcia | 2017-09-13 10:28:17 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2017-09-26 14:46:23 +0200 |
| commit | b5806108d20fc32b4692e721d8bd6376f4ca4a69 (patch) | |
| tree | 85e7f935c7dfe158516c34b04bfc57923d146275 /util | |
| parent | iotests: Print full path of bad output if mismatch (diff) | |
| download | qemu-b5806108d20fc32b4692e721d8bd6376f4ca4a69.tar.gz qemu-b5806108d20fc32b4692e721d8bd6376f4ca4a69.tar.xz qemu-b5806108d20fc32b4692e721d8bd6376f4ca4a69.zip | |
throttle: Assert that bkt->max is valid in throttle_compute_wait()
If bkt->max == 0 and bkt->burst_length > 1 then we could have a
division by 0 in throttle_do_compute_wait(). That configuration is
however not permitted and is already detected by throttle_is_valid(),
but let's assert it in throttle_compute_wait() to make it explicit.
Found by Coverity (CID: 1381016).
Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'util')
| -rw-r--r-- | util/throttle.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/util/throttle.c b/util/throttle.c index 06bf916adc..b38e742da5 100644 --- a/util/throttle.c +++ b/util/throttle.c @@ -124,6 +124,7 @@ int64_t throttle_compute_wait(LeakyBucket *bkt) /* If the main bucket is not full yet we still have to check the * burst bucket in order to enforce the burst limit */ if (bkt->burst_length > 1) { + assert(bkt->max > 0); /* see throttle_is_valid() */ extra = bkt->burst_level - burst_bucket_size; if (extra > 0) { return throttle_do_compute_wait(bkt->max, extra); |