diff options
| author | Li Qiang | 2018-12-15 13:03:53 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin | 2019-01-15 01:31:04 +0100 |
| commit | da93b82079dcb43885a84bc25b746fd15ae29dfb (patch) | |
| tree | e6a7c6f32713f584ba0116b3300707961d44f502 /util | |
| parent | vhost-user: fix ioeventfd_enabled (diff) | |
| download | qemu-da93b82079dcb43885a84bc25b746fd15ae29dfb.tar.gz qemu-da93b82079dcb43885a84bc25b746fd15ae29dfb.tar.xz qemu-da93b82079dcb43885a84bc25b746fd15ae29dfb.zip | |
util: check the return value of fcntl in qemu_set_{block, nonblock}
Assert that the return value is not an error. This is like commit
7e6478e7d4f for qemu_set_cloexec.
Signed-off-by: Li Qiang <liq3ea@163.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'util')
| -rw-r--r-- | util/oslib-posix.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/util/oslib-posix.c b/util/oslib-posix.c index c1bee2a581..4ce1ba9ca4 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -233,14 +233,18 @@ void qemu_set_block(int fd) { int f; f = fcntl(fd, F_GETFL); - fcntl(fd, F_SETFL, f & ~O_NONBLOCK); + assert(f != -1); + f = fcntl(fd, F_SETFL, f & ~O_NONBLOCK); + assert(f != -1); } void qemu_set_nonblock(int fd) { int f; f = fcntl(fd, F_GETFL); - fcntl(fd, F_SETFL, f | O_NONBLOCK); + assert(f != -1); + f = fcntl(fd, F_SETFL, f | O_NONBLOCK); + assert(f != -1); } int socket_set_fast_reuse(int fd) |