summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--block/mirror.c2
-rw-r--r--job.c4
2 files changed, 3 insertions, 3 deletions
diff --git a/block/mirror.c b/block/mirror.c
index 75874c1806..efec2c7674 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -946,7 +946,6 @@ static int coroutine_fn mirror_run(Job *job, Error **errp)
while (!job_cancel_requested(&s->common.job) && !s->should_complete) {
job_yield(&s->common.job);
}
- s->common.job.cancelled = false;
goto immediate_exit;
}
@@ -1085,7 +1084,6 @@ static int coroutine_fn mirror_run(Job *job, Error **errp)
* completion.
*/
assert(QLIST_EMPTY(&bs->tracked_requests));
- s->common.job.cancelled = false;
need_drain = false;
break;
}
diff --git a/job.c b/job.c
index b0cf2d8374..dbfa67bb0a 100644
--- a/job.c
+++ b/job.c
@@ -217,7 +217,9 @@ const char *job_type_str(const Job *job)
bool job_is_cancelled(Job *job)
{
- return job->cancelled && job->force_cancel;
+ /* force_cancel may be true only if cancelled is true, too */
+ assert(job->cancelled || !job->force_cancel);
+ return job->force_cancel;
}
bool job_cancel_requested(Job *job)