Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | qapi: Fix missing 'if' checks in struct, union, alternate 'data' | Markus Armbruster | 2019-09-24 | 1 | -1/+0 |
| | | | | | | | | | | | | | | Commit 87adbbffd4..3e270dcacc "qapi: Add 'if' to (implicit struct|union|alternate) members" (v4.0.0) neglected test coverage, and promptly failed to check the conditions. Review fail. Recent commit "tests/qapi-schema: Demonstrate insufficient 'if' checking" added test coverage, demonstrating the bug. Fix it by add the missing check_if(). Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20190914153506.2151-13-armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> | ||||
* | tests/qapi-schema: Demonstrate insufficient 'if' checking | Markus Armbruster | 2019-09-24 | 1 | -0/+7 |
Cover invalid 'if' in struct members, features, union and alternate branches. Four out of four are broken. Mark FIXME. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20190914153506.2151-6-armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> [Comment typo fixed] |