summaryrefslogtreecommitdiffstats
path: root/src/server/iscsi.c
diff options
context:
space:
mode:
authorSimon Rettberg2025-11-12 15:00:25 +0100
committerSimon Rettberg2025-12-09 15:33:21 +0100
commitd6eafd3faf59c4a46ebefaf5958a6cc00d4d9ac8 (patch)
tree9cf4e3a7b7b3c8a7e0ca9e772125e2aab04791d8 /src/server/iscsi.c
parent[SERVER] iscsi: Implement NOP-In on idle timeout (diff)
downloaddnbd3-d6eafd3faf59c4a46ebefaf5958a6cc00d4d9ac8.tar.gz
dnbd3-d6eafd3faf59c4a46ebefaf5958a6cc00d4d9ac8.tar.xz
dnbd3-d6eafd3faf59c4a46ebefaf5958a6cc00d4d9ac8.zip
[SERVER] iscsi: Replace int8 with uint8, remove unused login flags
Diffstat (limited to 'src/server/iscsi.c')
-rw-r--r--src/server/iscsi.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/server/iscsi.c b/src/server/iscsi.c
index 8546284..256446a 100644
--- a/src/server/iscsi.c
+++ b/src/server/iscsi.c
@@ -2116,7 +2116,6 @@ static iscsi_connection *iscsi_connection_create(dnbd3_client_t *client)
conn->client = client;
conn->flags = 0;
conn->state = ISCSI_CONNECT_STATE_NEW;
- conn->login_phase = ISCSI_LOGIN_RESPONSE_FLAGS_NEXT_STAGE_SECURITY_NEGOTIATION;
conn->cid = 0U;
conn->stat_sn = 0UL;
conn->exp_cmd_sn = 0UL;
@@ -2676,7 +2675,7 @@ static int iscsi_connection_handle_reject(iscsi_connection *conn, const iscsi_pd
iscsi_reject_packet *reject_pkt = (iscsi_reject_packet *) response_pdu.bhs_pkt;
reject_pkt->opcode = ISCSI_OPCODE_SERVER_REJECT;
- reject_pkt->flags = -0x80;
+ reject_pkt->flags = 0x80;
reject_pkt->reason = (uint8_t) reason_code;
reject_pkt->reserved = 0U;
iscsi_put_be32( (uint8_t *) &reject_pkt->total_ahs_len, ds_len ); // TotalAHSLength is always 0 and DataSegmentLength is 24-bit, so write in one step.
@@ -2777,7 +2776,7 @@ static int iscsi_connection_handle_logout_req(iscsi_connection *conn, const iscs
iscsi_logout_response_packet *logout_response_pkt = (iscsi_logout_response_packet *) response_pdu.bhs_pkt;
logout_response_pkt->opcode = ISCSI_OPCODE_SERVER_LOGOUT_RES;
- logout_response_pkt->flags = -0x80;
+ logout_response_pkt->flags = 0x80;
const uint16_t cid = iscsi_get_be16(logout_req_pkt->cid);
@@ -3155,7 +3154,6 @@ static int iscsi_connection_handle_login_response(iscsi_connection *conn, iscsi_
// Client set the transition bit - requests to move on to next stage
switch ( ISCSI_LOGIN_RESPONSE_FLAGS_GET_NEXT_STAGE(login_response_pkt->flags) ) {
case ISCSI_LOGIN_RESPONSE_FLAGS_NEXT_STAGE_FULL_FEATURE_PHASE : {
- conn->login_phase = ISCSI_LOGIN_RESPONSE_FLAGS_NEXT_STAGE_FULL_FEATURE_PHASE;
iscsi_put_be16( (uint8_t *) &login_response_pkt->tsih, 42 );