diff options
| author | Michael Brown | 2011-02-25 11:40:08 +0100 |
|---|---|---|
| committer | Michael Brown | 2011-02-25 11:41:23 +0100 |
| commit | 9625132bf590b5fb74bfe98491e2e5649575801d (patch) | |
| tree | 709ef80c25455fac799a9b8bfe93616b040b9711 | |
| parent | [iscsi] Fix minor typo in ibft_set_ipaddr() (diff) | |
| download | ipxe-9625132bf590b5fb74bfe98491e2e5649575801d.tar.gz ipxe-9625132bf590b5fb74bfe98491e2e5649575801d.tar.xz ipxe-9625132bf590b5fb74bfe98491e2e5649575801d.zip | |
[iscsi] Verify the correct tag in NOP-In PDUs
We should be checking the target transfer tag, rather than the
initiator task tag.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
| -rw-r--r-- | src/net/tcp/iscsi.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/net/tcp/iscsi.c b/src/net/tcp/iscsi.c index 6ef4c8968..f80186f7e 100644 --- a/src/net/tcp/iscsi.c +++ b/src/net/tcp/iscsi.c @@ -617,7 +617,7 @@ static int iscsi_rx_nop_in ( struct iscsi_session *iscsi, * (not the reserved 0xffffffff), the initiator MUST respond * with a NOP-Out". Since we never send unsolicited NOP-Outs, * my reading of this is that we can handle all permitted - * NOP-Ins (which must have ITT set to 0xffffffff) by simply + * NOP-Ins (which must have TTT set to 0xffffffff) by simply * ignoring them. * * There is some ambiguity in the RFC, since there are other @@ -628,9 +628,9 @@ static int iscsi_rx_nop_in ( struct iscsi_session *iscsi, * rather than just having the target drop the connection when * it times out waiting for the NOP-Out response. */ - if ( nop_in->itt != htonl ( ISCSI_TAG_RESERVED ) ) { - DBGC ( iscsi, "iSCSI %p received invalid NOP-In with ITT " - "%08x\n", iscsi, ntohl ( nop_in->itt ) ); + if ( nop_in->ttt != htonl ( ISCSI_TAG_RESERVED ) ) { + DBGC ( iscsi, "iSCSI %p received invalid NOP-In with TTT " + "%08x\n", iscsi, ntohl ( nop_in->ttt ) ); return -EPROTO_INVALID_NOP_IN; } |