diff options
| author | Michael Brown | 2006-05-19 19:50:49 +0200 |
|---|---|---|
| committer | Michael Brown | 2006-05-19 19:50:49 +0200 |
| commit | b9cbae58fa91bd1fcdeed121c88cf1230f4be5cd (patch) | |
| tree | 99dac66c33f7c2bc98b74afd4ec287c34c7e73f0 | |
| parent | - made some of the bit shifting attribute access simpler (in my mind) (diff) | |
| download | ipxe-b9cbae58fa91bd1fcdeed121c88cf1230f4be5cd.tar.gz ipxe-b9cbae58fa91bd1fcdeed121c88cf1230f4be5cd.tar.xz ipxe-b9cbae58fa91bd1fcdeed121c88cf1230f4be5cd.zip | |
Expert advice tells me that we *do* have to explicitly state the
options even when we want to use the defaults.
| -rw-r--r-- | src/net/tcp/iscsi.c | 27 |
1 files changed, 16 insertions, 11 deletions
diff --git a/src/net/tcp/iscsi.c b/src/net/tcp/iscsi.c index d7c4b1207..5fa021183 100644 --- a/src/net/tcp/iscsi.c +++ b/src/net/tcp/iscsi.c @@ -259,17 +259,17 @@ static void iscsi_tx_data_out ( struct iscsi_session *iscsi ) { * HeaderDigest=None * DataDigest=None * MaxConnections is irrelevant; we make only one connection anyway - * InitialR2T=Yes (default) [1] + * InitialR2T=Yes [1] * ImmediateData is irrelevant; we never send immediate data - * MaxRecvDataSegmentLength=8192 (default) - * MaxBurstLength=262144 (default) - * FirstBurstLength=262144 (default) + * MaxRecvDataSegmentLength=8192 (default; we don't care) + * MaxBurstLength=262144 (default; we don't care) + * FirstBurstLength=262144 (default; we don't care) * DefaultTime2Wait=0 [2] * DefaultTime2Retain=0 [2] - * MaxOutstandingR2T=1 (default) - * DataPDUInOrder=Yes (default) - * DataSequenceInOrder=Yes (default) - * ErrorRecoveryLevel=0 (default) + * MaxOutstandingR2T=1 + * DataPDUInOrder=Yes + * DataSequenceInOrder=Yes + * ErrorRecoveryLevel=0 * * [1] InitialR2T has an OR resolution function, so the target may * force us to use it. We therefore simplify our logic by always @@ -285,12 +285,17 @@ static int iscsi_build_login_request_strings ( struct iscsi_session *iscsi, "InitiatorName=%s%c" "TargetName=%s%c" "SessionType=Normal%c" - "DataDigest=None%c" "HeaderDigest=None%c" + "DataDigest=None%c" + "InitialR2T=Yes%c" "DefaultTime2Wait=0%c" - "DefaultTime2Retain=0%c", + "DefaultTime2Retain=0%c" + "MaxOutstandingR2T=1%c" + "DataPDUInOrder=Yes%c" + "DataSequenceInOrder=Yes%c" + "ErrorRecoveryLevel=0%c", iscsi->initiator, 0, iscsi->target, 0, - 0, 0, 0, 0, 0 ); + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ); } /** |