summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Brown2011-03-30 01:33:48 +0200
committerMichael Brown2011-03-30 01:34:09 +0200
commitc3e20868483ed6ef41316bd5aa52543c3ccecb3d (patch)
tree2de300972a1a3a4515d51ba78d2798f82068f454
parent[efi] Ensure that all drivers are shut down before the OS boots (diff)
downloadipxe-c3e20868483ed6ef41316bd5aa52543c3ccecb3d.tar.gz
ipxe-c3e20868483ed6ef41316bd5aa52543c3ccecb3d.tar.xz
ipxe-c3e20868483ed6ef41316bd5aa52543c3ccecb3d.zip
[forcedeth] Never change the NVREG_TRANSMITPOLL_MAC_ADDR_REV flag
iPXE operates the forcedeth NIC in promiscuous mode, and never changes the unicast MAC address filter registers. We should not therefore set the flag indicating (to other drivers loaded later) that the MAC address order has already been corrected. Reported-by: Tal Aloni <tal.aloni.il@gmail.com> Tested-by: Tal Aloni <tal.aloni.il@gmail.com> Signed-off-by: Michael Brown <mcb30@ipxe.org>
-rw-r--r--src/drivers/net/forcedeth.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/src/drivers/net/forcedeth.c b/src/drivers/net/forcedeth.c
index bb3d6844..c34a4296 100644
--- a/src/drivers/net/forcedeth.c
+++ b/src/drivers/net/forcedeth.c
@@ -1098,11 +1098,6 @@ nv_setup_mac_addr ( struct forcedeth_private *priv )
dev->hw_addr[3] = ( orig_mac[0] >> 16 ) & 0xff;
dev->hw_addr[4] = ( orig_mac[0] >> 8 ) & 0xff;
dev->hw_addr[5] = ( orig_mac[0] >> 0 ) & 0xff;
-
- writel ( txreg | NVREG_TRANSMITPOLL_MAC_ADDR_REV,
- ioaddr + NvRegTransmitPoll );
-
- DBG ( "set workaround bit for reversed mac addr\n" );
}
if ( ! is_valid_ether_addr ( dev->hw_addr ) )