diff options
| author | Michael Brown | 2015-03-04 19:48:19 +0100 |
|---|---|---|
| committer | Michael Brown | 2015-03-05 01:59:38 +0100 |
| commit | fbc4ba4b4ed13cc86cb8fdea0bac6c3be0164ed5 (patch) | |
| tree | a0c504e297806aa88e89a04e694333a7c5172757 /src/arch/i386/prefix | |
| parent | [build] Use REQUIRE_OBJECT() to drag in per-object configuration (diff) | |
| download | ipxe-fbc4ba4b4ed13cc86cb8fdea0bac6c3be0164ed5.tar.gz ipxe-fbc4ba4b4ed13cc86cb8fdea0bac6c3be0164ed5.tar.xz ipxe-fbc4ba4b4ed13cc86cb8fdea0bac6c3be0164ed5.zip | |
[build] Fix the REQUIRE_SYMBOL mechanism
At some point in the past few years, binutils became more aggressive
at removing unused symbols. To function as a symbol requirement, a
relocation record must now be in a section marked with @progbits and
must not be in a section which gets discarded during the link (either
via --gc-sections or via /DISCARD/).
Update REQUIRE_SYMBOL() to generate relocation records meeting these
criteria. To minimise the impact upon the final binary size, we use
existing symbols (specified via the REQUIRING_SYMBOL() macro) as the
relocation targets where possible. We use R_386_NONE or R_X86_64_NONE
relocation types to prevent any actual unwanted relocation taking
place. Where no suitable symbol exists for REQUIRING_SYMBOL() (such
as in config.c), the macro PROVIDE_REQUIRING_SYMBOL() can be used to
generate a one-byte-long symbol to act as the relocation target.
If there are versions of binutils for which this approach fails, then
the fallback will probably involve killing off REQUEST_SYMBOL(),
redefining REQUIRE_SYMBOL() to use the current definition of
REQUEST_SYMBOL(), and postprocessing the linked ELF file with
something along the lines of "nm -u | wc -l" to check that there are
no undefined symbols remaining.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/arch/i386/prefix')
| -rw-r--r-- | src/arch/i386/prefix/kkkpxeprefix.S | 1 | ||||
| -rw-r--r-- | src/arch/i386/prefix/romprefix.S | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/src/arch/i386/prefix/kkkpxeprefix.S b/src/arch/i386/prefix/kkkpxeprefix.S index 999fe1bf5..6e43cd26a 100644 --- a/src/arch/i386/prefix/kkkpxeprefix.S +++ b/src/arch/i386/prefix/kkkpxeprefix.S @@ -8,6 +8,7 @@ FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL ) /* Provide the PXENV_FILE_EXIT_HOOK API call */ +REQUIRING_SYMBOL ( _kkkpxe_start ) REQUIRE_OBJECT ( pxe_exit_hook ) #define PXELOADER_KEEP_UNDI diff --git a/src/arch/i386/prefix/romprefix.S b/src/arch/i386/prefix/romprefix.S index 08fcf73b1..777b9e042 100644 --- a/src/arch/i386/prefix/romprefix.S +++ b/src/arch/i386/prefix/romprefix.S @@ -875,5 +875,8 @@ wait_for_tick: ret .size wait_for_tick, . - wait_for_tick +/* Drag in objects via _rom_start */ +REQUIRING_SYMBOL ( _rom_start ) + /* Drag in ROM configuration */ REQUIRE_OBJECT ( config_romprefix ) |