diff options
| author | Michael Brown | 2013-12-03 17:48:56 +0100 |
|---|---|---|
| committer | Michael Brown | 2013-12-05 01:37:02 +0100 |
| commit | 22001cb206c1320aee27f679a63d2171d35e99c5 (patch) | |
| tree | a972bb914371a68d4925dcc007238dcb836546ba /src/core/memmap_settings.c | |
| parent | [fbcon] Add support for displaying a cursor (diff) | |
| download | ipxe-22001cb206c1320aee27f679a63d2171d35e99c5.tar.gz ipxe-22001cb206c1320aee27f679a63d2171d35e99c5.tar.xz ipxe-22001cb206c1320aee27f679a63d2171d35e99c5.zip | |
[settings] Explicitly separate the concept of a completed fetched setting
The fetch_setting() family of functions may currently modify the
definition of the specified setting (e.g. to add missing type
information). Clean up this interface by requiring callers to provide
an explicit buffer to contain the completed definition of the fetched
setting, if required.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/core/memmap_settings.c')
| -rw-r--r-- | src/core/memmap_settings.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/core/memmap_settings.c b/src/core/memmap_settings.c index f06b8750..906fba12 100644 --- a/src/core/memmap_settings.c +++ b/src/core/memmap_settings.c @@ -108,7 +108,7 @@ FILE_LICENCE ( GPL2_OR_LATER ); #define MEMMAP_SCALE( tag ) ( (tag) & 0x3f ) /** Memory map settings scope */ -static struct settings_scope memmap_settings_scope; +static const struct settings_scope memmap_settings_scope; /** * Check applicability of memory map setting @@ -118,7 +118,7 @@ static struct settings_scope memmap_settings_scope; * @ret applies Setting applies within this settings block */ static int memmap_settings_applies ( struct settings *settings __unused, - struct setting *setting ) { + const struct setting *setting ) { return ( setting->scope == &memmap_settings_scope ); } @@ -231,7 +231,7 @@ struct init_fn memmap_settings_init_fn __init_fn ( INIT_NORMAL ) = { }; /** Memory map predefined settings */ -struct setting memmap_predefined_settings[] __setting ( SETTING_MISC ) = { +const struct setting memmap_predefined_settings[] __setting ( SETTING_MISC ) = { { .name = "memsize", .description = "Memory size (in MB)", |