diff options
| author | Michael Brown | 2013-12-03 17:48:56 +0100 |
|---|---|---|
| committer | Michael Brown | 2013-12-05 01:37:02 +0100 |
| commit | 22001cb206c1320aee27f679a63d2171d35e99c5 (patch) | |
| tree | a972bb914371a68d4925dcc007238dcb836546ba /src/core/nvo.c | |
| parent | [fbcon] Add support for displaying a cursor (diff) | |
| download | ipxe-22001cb206c1320aee27f679a63d2171d35e99c5.tar.gz ipxe-22001cb206c1320aee27f679a63d2171d35e99c5.tar.xz ipxe-22001cb206c1320aee27f679a63d2171d35e99c5.zip | |
[settings] Explicitly separate the concept of a completed fetched setting
The fetch_setting() family of functions may currently modify the
definition of the specified setting (e.g. to add missing type
information). Clean up this interface by requiring callers to provide
an explicit buffer to contain the completed definition of the fetched
setting, if required.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/core/nvo.c')
| -rw-r--r-- | src/core/nvo.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/core/nvo.c b/src/core/nvo.c index 4c871b2f..e135d2b4 100644 --- a/src/core/nvo.c +++ b/src/core/nvo.c @@ -193,7 +193,7 @@ static int nvo_save ( struct nvo_block *nvo ) { * @ret applies Setting applies within this settings block */ int nvo_applies ( struct settings *settings __unused, - struct setting *setting ) { + const struct setting *setting ) { return ( ( setting->scope == NULL ) && dhcpopt_applies ( setting->tag ) ); @@ -208,7 +208,7 @@ int nvo_applies ( struct settings *settings __unused, * @v len Length of setting data * @ret rc Return status code */ -static int nvo_store ( struct settings *settings, struct setting *setting, +static int nvo_store ( struct settings *settings, const struct setting *setting, const void *data, size_t len ) { struct nvo_block *nvo = container_of ( settings, struct nvo_block, settings ); |