diff options
author | Michael Brown | 2017-03-22 09:47:46 +0100 |
---|---|---|
committer | Michael Brown | 2017-03-22 10:18:02 +0100 |
commit | 39ef530088859ccbbcf29bf6af2cf9f0307dc476 (patch) | |
tree | 1f90063aa65d6fa2065bdb7f430aebf70623856e /src/drivers/net/eoib.c | |
parent | [build] Avoid confusing sparse in single-argument DBG() macros (diff) | |
download | ipxe-39ef530088859ccbbcf29bf6af2cf9f0307dc476.tar.gz ipxe-39ef530088859ccbbcf29bf6af2cf9f0307dc476.tar.xz ipxe-39ef530088859ccbbcf29bf6af2cf9f0307dc476.zip |
[infiniband] Return status code from ib_create_cq() and ib_create_qp()
Any underlying errors arising during ib_create_cq() or ib_create_qp()
are lost since the functions simply return NULL on error. This makes
debugging harder, since a debug-enabled build is required to discover
the root cause of the error.
Fix by returning a status code from these functions, thereby allowing
any underlying errors to be propagated.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/drivers/net/eoib.c')
-rw-r--r-- | src/drivers/net/eoib.c | 19 |
1 files changed, 8 insertions, 11 deletions
diff --git a/src/drivers/net/eoib.c b/src/drivers/net/eoib.c index e8247837..ba291295 100644 --- a/src/drivers/net/eoib.c +++ b/src/drivers/net/eoib.c @@ -538,22 +538,19 @@ static int eoib_open ( struct net_device *netdev ) { } /* Allocate completion queue */ - eoib->cq = ib_create_cq ( ibdev, EOIB_NUM_CQES, &eoib_cq_op ); - if ( ! eoib->cq ) { - DBGC ( eoib, "EoIB %s could not allocate completion queue\n", - eoib->name ); - rc = -ENOMEM; + if ( ( rc = ib_create_cq ( ibdev, EOIB_NUM_CQES, &eoib_cq_op, + &eoib->cq ) ) != 0 ) { + DBGC ( eoib, "EoIB %s could not create completion queue: %s\n", + eoib->name, strerror ( rc ) ); goto err_create_cq; } /* Allocate queue pair */ - eoib->qp = ib_create_qp ( ibdev, IB_QPT_UD, EOIB_NUM_SEND_WQES, + if ( ( rc = ib_create_qp ( ibdev, IB_QPT_UD, EOIB_NUM_SEND_WQES, eoib->cq, EOIB_NUM_RECV_WQES, eoib->cq, - &eoib_qp_op, netdev->name ); - if ( ! eoib->qp ) { - DBGC ( eoib, "EoIB %s could not allocate queue pair\n", - eoib->name ); - rc = -ENOMEM; + &eoib_qp_op, netdev->name, &eoib->qp ) )!=0){ + DBGC ( eoib, "EoIB %s could not create queue pair: %s\n", + eoib->name, strerror ( rc ) ); goto err_create_qp; } ib_qp_set_ownerdata ( eoib->qp, eoib ); |