summaryrefslogtreecommitdiffstats
path: root/src/drivers/net/ipoib.c
diff options
context:
space:
mode:
authorMichael Brown2015-07-06 14:06:55 +0200
committerMichael Brown2015-07-06 14:10:40 +0200
commit652e5a96db85a86633b5c40fc1699ae5c8039942 (patch)
tree67fbbd16a638d97d04607048f0629459ee7ec2bb /src/drivers/net/ipoib.c
parent[tcp] Gracefully close connections during shutdown (diff)
downloadipxe-652e5a96db85a86633b5c40fc1699ae5c8039942.tar.gz
ipxe-652e5a96db85a86633b5c40fc1699ae5c8039942.tar.xz
ipxe-652e5a96db85a86633b5c40fc1699ae5c8039942.zip
[ipoib] Transmit multicast packets as broadcasts
Multicast MAC addresses will never have REMAC cache entries, and the corresponding multicast IPoIB MAC address cannot be obtained simply by issuing an ARP request. For the trivial volume of multicast packets that we expect to send in any realistic scenario, the simplest solution is to send them as broadcasts instead. Reported-by: Wissam Shoukair <wissams@mellanox.com> Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/drivers/net/ipoib.c')
-rw-r--r--src/drivers/net/ipoib.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/drivers/net/ipoib.c b/src/drivers/net/ipoib.c
index bec4bbae..7ecb2c5d 100644
--- a/src/drivers/net/ipoib.c
+++ b/src/drivers/net/ipoib.c
@@ -146,8 +146,10 @@ static struct ipoib_mac * ipoib_find_remac ( struct ipoib_device *ipoib,
const struct ipoib_remac *remac ) {
struct ipoib_peer *peer;
- /* Check for broadcast REMAC */
- if ( is_broadcast_ether_addr ( remac ) )
+ /* Check for broadcast or multicast REMAC. We transmit
+ * multicasts as broadcasts for simplicity.
+ */
+ if ( is_multicast_ether_addr ( remac ) )
return &ipoib->broadcast;
/* Try to find via REMAC cache */