diff options
| author | Michael Brown | 2010-11-08 03:51:18 +0100 |
|---|---|---|
| committer | Michael Brown | 2010-11-08 04:15:28 +0100 |
| commit | ea631f6fb8dbffe3081ecf29eafa62ecd38ec64f (patch) | |
| tree | f27d347fc48c524e172a4bdeea80976a26b9904a /src/hci | |
| parent | [list] Extend list-manipulation assertions to all list-handling functions (diff) | |
| download | ipxe-ea631f6fb8dbffe3081ecf29eafa62ecd38ec64f.tar.gz ipxe-ea631f6fb8dbffe3081ecf29eafa62ecd38ec64f.tar.xz ipxe-ea631f6fb8dbffe3081ecf29eafa62ecd38ec64f.zip | |
[list] Add list_first_entry()
There are several points in the iPXE codebase where
list_for_each_entry() is (ab)used to extract only the first entry from
a list. Add a macro list_first_entry() to make this code easier to
read.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/hci')
| -rw-r--r-- | src/hci/commands/fcmgmt_cmd.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/hci/commands/fcmgmt_cmd.c b/src/hci/commands/fcmgmt_cmd.c index 3a4e28469..98647c134 100644 --- a/src/hci/commands/fcmgmt_cmd.c +++ b/src/hci/commands/fcmgmt_cmd.c @@ -144,12 +144,11 @@ static int fcels_exec ( int argc, char **argv ) { } } else { /* Use first port */ - if ( list_empty ( &fc_ports ) ) { + port = list_first_entry ( &fc_ports, struct fc_port, list ); + if ( ! port ) { printf ( "No ports\n" ); return 1; } - list_for_each_entry ( port, &fc_ports, list ) - break; } assert ( port != NULL ); |