diff options
| author | Michael Brown | 2018-02-20 11:56:31 +0100 |
|---|---|---|
| committer | Michael Brown | 2018-02-20 11:56:31 +0100 |
| commit | c89a446cf09f30a121ae21d91f4a1aa071044084 (patch) | |
| tree | d9b8a253fc68ac4e97221ad5dfae8707c5bab873 /src/include/assert.h | |
| parent | [xhci] Consume event TRB before reporting completion to USB core (diff) | |
| download | ipxe-c89a446cf09f30a121ae21d91f4a1aa071044084.tar.gz ipxe-c89a446cf09f30a121ae21d91f4a1aa071044084.tar.xz ipxe-c89a446cf09f30a121ae21d91f4a1aa071044084.zip | |
[efi] Run at TPL_CALLBACK to protect against UEFI timers
As noted in the comments, UEFI manages to combines the all of the
worst aspects of both a polling design (inefficiency and inability to
sleep until something interesting happens) and of an interrupt-driven
design (the complexity of code that could be preempted at any time,
thanks to UEFI timers).
This causes problems in particular for UEFI USB keyboards: the
keyboard driver calls UsbAsyncInterruptTransfer() to set up a periodic
timer which is used to poll the USB bus. This poll may interrupt a
critical section within iPXE, typically resulting in list corruption
and either a hang or reboot.
Work around this problem by mirroring the BIOS design, in which we run
with interrupts disabled almost all of the time.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/include/assert.h')
0 files changed, 0 insertions, 0 deletions
