diff options
| author | Michael Brown | 2015-05-01 17:28:45 +0200 |
|---|---|---|
| committer | Michael Brown | 2015-05-01 17:29:11 +0200 |
| commit | 50e703a534e3be4496600562dab5cd4561cd5b71 (patch) | |
| tree | d4bbb99952e53866016db632a982fc099612750e /src/include/ipxe | |
| parent | [vram] Add "vram" built-in setting to dump video RAM (diff) | |
| download | ipxe-50e703a534e3be4496600562dab5cd4561cd5b71.tar.gz ipxe-50e703a534e3be4496600562dab5cd4561cd5b71.tar.xz ipxe-50e703a534e3be4496600562dab5cd4561cd5b71.zip | |
[usb] Include setup packet within I/O buffer for message transfers
The USB API currently assumes that host controllers will have
immediate data buffer space available in which to store the setup
packet. This is true for xHCI, partially true for EHCI (which happens
to have 12 bytes of padding in each transfer descriptor due to
alignment requirements), and not true at all for UHCI.
Include the setup packet within the I/O buffer passed to the host
controller's message() method, thereby eliminating the requirement for
host controllers to provide immediate data buffers.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/include/ipxe')
| -rw-r--r-- | src/include/ipxe/usb.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/include/ipxe/usb.h b/src/include/ipxe/usb.h index b3803cd18..991a6f44e 100644 --- a/src/include/ipxe/usb.h +++ b/src/include/ipxe/usb.h @@ -433,12 +433,10 @@ struct usb_endpoint_host_operations { /** Enqueue message transfer * * @v ep USB endpoint - * @v packet Setup packet - * @v iobuf I/O buffer (if any) + * @v iobuf I/O buffer * @ret rc Return status code */ int ( * message ) ( struct usb_endpoint *ep, - struct usb_setup_packet *setup, struct io_buffer *iobuf ); /** Enqueue stream transfer * |