diff options
| author | Michael Brown | 2014-07-31 13:22:40 +0200 |
|---|---|---|
| committer | Michael Brown | 2014-07-31 13:50:09 +0200 |
| commit | 4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c (patch) | |
| tree | 7d6cc53d78cc711330425810dd78320ab5aaaf81 /src/include | |
| parent | [efi] Allow compiler to perform type checks on EFI_HANDLE (diff) | |
| download | ipxe-4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c.tar.gz ipxe-4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c.tar.xz ipxe-4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c.zip | |
[efi] Avoid unnecessarily passing pointers to EFI_HANDLEs
efi_file_install() and efi_download_install() are both used to install
onto existing handles. There is therefore no need to allow for each
of their calls to InstallMultipleProtocolInterfaces() to create a new
handle.
By passing the handle directly (rather than a pointer to the handle),
we avoid potential confusion (and erroneous debug message colours).
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/ipxe/efi/efi_download.h | 4 | ||||
| -rw-r--r-- | src/include/ipxe/efi/efi_file.h | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/include/ipxe/efi/efi_download.h b/src/include/ipxe/efi/efi_download.h index 3ce49722..740fcadf 100644 --- a/src/include/ipxe/efi/efi_download.h +++ b/src/include/ipxe/efi/efi_download.h @@ -151,7 +151,7 @@ struct _IPXE_DOWNLOAD_PROTOCOL { 0x3eaeaebd, 0xdecf, 0x493b, { 0x9b, 0xd1, 0xcd, 0xb2, 0xde, 0xca, 0xe7, 0x19 } \ } -extern int efi_download_install ( EFI_HANDLE *device ); -extern void efi_download_uninstall ( EFI_HANDLE device ); +extern int efi_download_install ( EFI_HANDLE handle ); +extern void efi_download_uninstall ( EFI_HANDLE handle ); #endif /* _IPXE_DOWNLOAD_H */ diff --git a/src/include/ipxe/efi/efi_file.h b/src/include/ipxe/efi/efi_file.h index 0d75cf5b..e4db0305 100644 --- a/src/include/ipxe/efi/efi_file.h +++ b/src/include/ipxe/efi/efi_file.h @@ -7,7 +7,7 @@ * */ -extern int efi_file_install ( EFI_HANDLE *handle ); +extern int efi_file_install ( EFI_HANDLE handle ); extern void efi_file_uninstall ( EFI_HANDLE handle ); #endif /* _IPXE_EFI_FILE_H */ |