summaryrefslogtreecommitdiffstats
path: root/src/include
diff options
context:
space:
mode:
authorLadi Prosek2016-12-16 10:54:32 +0100
committerMichael Brown2017-01-22 14:18:28 +0100
commite45451c6994f6e93729ee3860e45fa965483356f (patch)
tree42a29a9d741bedf9e99aec7e84723c6dc12dcb55 /src/include
parent[build] Add %.vhd target for building VM bootable disk images (diff)
downloadipxe-e45451c6994f6e93729ee3860e45fa965483356f.tar.gz
ipxe-e45451c6994f6e93729ee3860e45fa965483356f.tar.xz
ipxe-e45451c6994f6e93729ee3860e45fa965483356f.zip
[virtio] Cap queue size to MAX_QUEUE_NUM
vpm_find_vqs incorrectly accepted the host provided queue size with no regard to iPXE's internal limitations. Virtio 1.0 makes it possible for the driver to override the queue size to reduce memory requirements and iPXE is a great use case for this feature. Also removing the extra vq->vring.num assignment which is already handled in vring_init. Signed-off-by: Ladi Prosek <lprosek@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/include')
-rw-r--r--src/include/ipxe/virtio-ring.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/include/ipxe/virtio-ring.h b/src/include/ipxe/virtio-ring.h
index 6ba550b5..d2ded300 100644
--- a/src/include/ipxe/virtio-ring.h
+++ b/src/include/ipxe/virtio-ring.h
@@ -95,7 +95,7 @@ static inline void vring_init(struct vring *vr,
unsigned int i;
unsigned long pa;
- vr->num = num;
+ vr->num = num;
/* physical address of desc must be page aligned */
@@ -103,13 +103,13 @@ static inline void vring_init(struct vring *vr,
pa = (pa + PAGE_MASK) & ~PAGE_MASK;
vr->desc = phys_to_virt(pa);
- vr->avail = (struct vring_avail *)&vr->desc[num];
+ vr->avail = (struct vring_avail *)&vr->desc[num];
/* physical address of used must be page aligned */
pa = virt_to_phys(&vr->avail->ring[num]);
pa = (pa + PAGE_MASK) & ~PAGE_MASK;
- vr->used = phys_to_virt(pa);
+ vr->used = phys_to_virt(pa);
for (i = 0; i < num - 1; i++)
vr->desc[i].next = i + 1;