diff options
| author | Michael Brown | 2014-07-31 13:22:40 +0200 |
|---|---|---|
| committer | Michael Brown | 2014-07-31 13:50:09 +0200 |
| commit | 4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c (patch) | |
| tree | 7d6cc53d78cc711330425810dd78320ab5aaaf81 /src/interface/efi/efi_download.c | |
| parent | [efi] Allow compiler to perform type checks on EFI_HANDLE (diff) | |
| download | ipxe-4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c.tar.gz ipxe-4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c.tar.xz ipxe-4a480f1d1565aa5972c4fc27ceec8ae4b9b1e86c.zip | |
[efi] Avoid unnecessarily passing pointers to EFI_HANDLEs
efi_file_install() and efi_download_install() are both used to install
onto existing handles. There is therefore no need to allow for each
of their calls to InstallMultipleProtocolInterfaces() to create a new
handle.
By passing the handle directly (rather than a pointer to the handle),
we avoid potential confusion (and erroneous debug message colours).
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/interface/efi/efi_download.c')
| -rw-r--r-- | src/interface/efi/efi_download.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/interface/efi/efi_download.c b/src/interface/efi/efi_download.c index 522276ac..1218852e 100644 --- a/src/interface/efi/efi_download.c +++ b/src/interface/efi/efi_download.c @@ -205,13 +205,13 @@ static IPXE_DOWNLOAD_PROTOCOL ipxe_download_protocol_interface = { * @v handle EFI handle * @ret rc Return status code */ -int efi_download_install ( EFI_HANDLE *handle ) { +int efi_download_install ( EFI_HANDLE handle ) { EFI_BOOT_SERVICES *bs = efi_systab->BootServices; EFI_STATUS efirc; int rc; efirc = bs->InstallMultipleProtocolInterfaces ( - handle, + &handle, &ipxe_download_protocol_guid, &ipxe_download_protocol_interface, NULL ); |