diff options
| author | Michael Brown | 2013-12-03 17:48:56 +0100 |
|---|---|---|
| committer | Michael Brown | 2013-12-05 01:37:02 +0100 |
| commit | 22001cb206c1320aee27f679a63d2171d35e99c5 (patch) | |
| tree | a972bb914371a68d4925dcc007238dcb836546ba /src/net/dhcppkt.c | |
| parent | [fbcon] Add support for displaying a cursor (diff) | |
| download | ipxe-22001cb206c1320aee27f679a63d2171d35e99c5.tar.gz ipxe-22001cb206c1320aee27f679a63d2171d35e99c5.tar.xz ipxe-22001cb206c1320aee27f679a63d2171d35e99c5.zip | |
[settings] Explicitly separate the concept of a completed fetched setting
The fetch_setting() family of functions may currently modify the
definition of the specified setting (e.g. to add missing type
information). Clean up this interface by requiring callers to provide
an explicit buffer to contain the completed definition of the fetched
setting, if required.
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/net/dhcppkt.c')
| -rw-r--r-- | src/net/dhcppkt.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/net/dhcppkt.c b/src/net/dhcppkt.c index 3722c09e..a9a6d3a9 100644 --- a/src/net/dhcppkt.c +++ b/src/net/dhcppkt.c @@ -226,7 +226,7 @@ int dhcppkt_fetch ( struct dhcp_packet *dhcppkt, unsigned int tag, * @ret applies Setting applies within this settings block */ static int dhcppkt_settings_applies ( struct settings *settings, - struct setting *setting ) { + const struct setting *setting ) { struct dhcp_packet *dhcppkt = container_of ( settings, struct dhcp_packet, settings ); @@ -244,7 +244,7 @@ static int dhcppkt_settings_applies ( struct settings *settings, * @ret rc Return status code */ static int dhcppkt_settings_store ( struct settings *settings, - struct setting *setting, + const struct setting *setting, const void *data, size_t len ) { struct dhcp_packet *dhcppkt = container_of ( settings, struct dhcp_packet, settings ); |