summaryrefslogtreecommitdiffstats
path: root/src/net/tcp.c
diff options
context:
space:
mode:
authorMichael Brown2010-11-08 03:51:18 +0100
committerMichael Brown2010-11-08 04:15:28 +0100
commitea631f6fb8dbffe3081ecf29eafa62ecd38ec64f (patch)
treef27d347fc48c524e172a4bdeea80976a26b9904a /src/net/tcp.c
parent[list] Extend list-manipulation assertions to all list-handling functions (diff)
downloadipxe-ea631f6fb8dbffe3081ecf29eafa62ecd38ec64f.tar.gz
ipxe-ea631f6fb8dbffe3081ecf29eafa62ecd38ec64f.tar.xz
ipxe-ea631f6fb8dbffe3081ecf29eafa62ecd38ec64f.zip
[list] Add list_first_entry()
There are several points in the iPXE codebase where list_for_each_entry() is (ab)used to extract only the first entry from a list. Add a macro list_first_entry() to make this code easier to read. Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/net/tcp.c')
-rw-r--r--src/net/tcp.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/net/tcp.c b/src/net/tcp.c
index 1c824bdf..42064034 100644
--- a/src/net/tcp.c
+++ b/src/net/tcp.c
@@ -1014,9 +1014,8 @@ static void tcp_process_rx_queue ( struct tcp_connection *tcp ) {
* queue, since tcp_discard() may remove packets from the RX
* queue while we are processing.
*/
- while ( ! list_empty ( &tcp->rx_queue ) ) {
- list_for_each_entry ( iobuf, &tcp->rx_queue, list )
- break;
+ while ( ( iobuf = list_first_entry ( &tcp->rx_queue, struct io_buffer,
+ list ) ) ) {
/* Stop processing when we hit the first gap */
tcpqhdr = iobuf->data;