diff options
author | Michael Brown | 2008-10-12 16:04:37 +0200 |
---|---|---|
committer | Michael Brown | 2008-10-12 16:11:20 +0200 |
commit | f945d6d201901b204eceae0b8ee7d6a8d0912402 (patch) | |
tree | 0d79f3ea2be207e516638da6c5dd3e079a28537a /src/net | |
parent | [commands] Fix config command to accept zero arguments (diff) | |
download | ipxe-f945d6d201901b204eceae0b8ee7d6a8d0912402.tar.gz ipxe-f945d6d201901b204eceae0b8ee7d6a8d0912402.tar.xz ipxe-f945d6d201901b204eceae0b8ee7d6a8d0912402.zip |
[retry] Use a separate flag to indicate that a retry timer is running
Using start==0 to indicate a stopped timer is dangerous, because 0 is a
valid value for the current tick counter.
Diffstat (limited to 'src/net')
-rw-r--r-- | src/net/retry.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/src/net/retry.c b/src/net/retry.c index 2a645c97..cd793a7f 100644 --- a/src/net/retry.c +++ b/src/net/retry.c @@ -55,9 +55,10 @@ static LIST_HEAD ( timers ); * be stopped and the timer's callback function will be called. */ void start_timer ( struct retry_timer *timer ) { - if ( ! timer_running ( timer ) ) + if ( ! timer->running ) list_add ( &timer->list, &timers ); timer->start = currticks(); + timer->running = 1; /* 0 means "use default timeout" */ if ( timer->min_timeout == 0 ) @@ -82,6 +83,8 @@ void start_timer ( struct retry_timer *timer ) { void start_timer_fixed ( struct retry_timer *timer, unsigned long timeout ) { start_timer ( timer ); timer->timeout = timeout; + DBG2 ( "Timer %p expiry time changed to %ld\n", + timer, ( timer->start + timer->timeout ) ); } /** @@ -97,12 +100,12 @@ void stop_timer ( struct retry_timer *timer ) { unsigned long runtime; /* If timer was already stopped, do nothing */ - if ( ! timer_running ( timer ) ) + if ( ! timer->running ) return; list_del ( &timer->list ); runtime = ( now - timer->start ); - timer->start = 0; + timer->running = 0; DBG2 ( "Timer %p stopped at time %ld (ran for %ld)\n", timer, now, runtime ); @@ -144,8 +147,9 @@ static void timer_expired ( struct retry_timer *timer ) { /* Stop timer without performing RTT calculations */ DBG2 ( "Timer %p stopped at time %ld on expiry\n", timer, currticks() ); + assert ( timer->running ); list_del ( &timer->list ); - timer->start = 0; + timer->running = 0; timer->count++; /* Back off the timeout value */ |