summaryrefslogtreecommitdiffstats
path: root/src/usr/imgmgmt.c
diff options
context:
space:
mode:
authorMichael Brown2008-07-08 04:50:44 +0200
committerMichael Brown2008-07-08 04:50:44 +0200
commit0436e417bcb9acd658b73a65172474a71eb12b83 (patch)
treef943d7ba1a70016b8a2d8246b6d60a599c68e73a /src/usr/imgmgmt.c
parent[image] Revert "clear LOADED flag" patch (diff)
downloadipxe-0436e417bcb9acd658b73a65172474a71eb12b83.tar.gz
ipxe-0436e417bcb9acd658b73a65172474a71eb12b83.tar.xz
ipxe-0436e417bcb9acd658b73a65172474a71eb12b83.zip
[image] Fail "imgexec"/"boot" if the image to execute is ambiguous
If there is more than one loaded image, refuse to automatically select the image to execute. There are at least two possible cases, with different "correct" answers: 1. User loads image A by mistake, then loads image B and types "boot". User wants to execute image B. 2. User loads image A, then loads image B (which patches image A), then types "boot". User wants to execute image A. If a user actually wants to load multiple images, they must explicitly specify which image is to be executed.
Diffstat (limited to 'src/usr/imgmgmt.c')
-rw-r--r--src/usr/imgmgmt.c14
1 files changed, 9 insertions, 5 deletions
diff --git a/src/usr/imgmgmt.c b/src/usr/imgmgmt.c
index bead4867..be153f87 100644
--- a/src/usr/imgmgmt.c
+++ b/src/usr/imgmgmt.c
@@ -86,19 +86,23 @@ int imgexec ( struct image *image ) {
}
/**
- * Identify the first loaded image
+ * Identify the only loaded image
*
- * @ret image Image, or NULL
+ * @ret image Image, or NULL if 0 or >1 images are loaded
*/
struct image * imgautoselect ( void ) {
struct image *image;
+ struct image *selected_image = NULL;
+ int flagged_images = 0;
for_each_image ( image ) {
- if ( image->flags & IMAGE_LOADED )
- return image;
+ if ( image->flags & IMAGE_LOADED ) {
+ selected_image = image;
+ flagged_images++;
+ }
}
- return NULL;
+ return ( ( flagged_images == 1 ) ? selected_image : NULL );
}
/**