diff options
| author | Daniel P. Berrange | 2013-03-05 16:18:20 +0100 |
|---|---|---|
| committer | Michael Brown | 2013-03-05 16:23:01 +0100 |
| commit | eb5a2ba5962579e514b377f5fdab7292be0fb2a7 (patch) | |
| tree | 0b5c350336055b2cd4043a9aa50fe2a20e34dfa7 /src/util | |
| parent | [undi] Work around specific devices with known broken interrupt behaviour (diff) | |
| download | ipxe-eb5a2ba5962579e514b377f5fdab7292be0fb2a7.tar.gz ipxe-eb5a2ba5962579e514b377f5fdab7292be0fb2a7.tar.xz ipxe-eb5a2ba5962579e514b377f5fdab7292be0fb2a7.zip | |
[zbin] Fix size used for memset in alloc_output_file
The output->buf field is a pointer, not an array, so sizeof() is not
applicable. We must use the allocated string length instead.
Identified by gcc:
util/zbin.c: In function ‘alloc_output_file’:
util/zbin.c:146:37: warning: argument to ‘sizeof’ in ‘memset’ call
is the same expression as the destination; did you mean to
dereference it? [-Wsizeof-pointer-memaccess]
memset ( output->buf, 0xff, sizeof ( output->buf ) );
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
Diffstat (limited to 'src/util')
| -rw-r--r-- | src/util/zbin.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/util/zbin.c b/src/util/zbin.c index 0dabaf1e..3b7cf95b 100644 --- a/src/util/zbin.c +++ b/src/util/zbin.c @@ -143,7 +143,7 @@ static int alloc_output_file ( size_t max_len, struct output_file *output ) { max_len ); return -1; } - memset ( output->buf, 0xff, sizeof ( output->buf ) ); + memset ( output->buf, 0xff, max_len ); return 0; } |