diff options
| author | Simon Rettberg | 2017-12-16 18:33:16 +0100 |
|---|---|---|
| committer | Simon Rettberg | 2017-12-16 18:33:16 +0100 |
| commit | cd55ead3e2810e209b726faca12fa749f6875d0f (patch) | |
| tree | 94b2f29b023e8a0c5100e1d06c974c3c04f890fd /modules-available/baseconfig/page.inc.php | |
| parent | Merge branch 'permission-manager' of openslx.org:openslx-ng/slx-admin into pe... (diff) | |
| download | slx-admin-cd55ead3e2810e209b726faca12fa749f6875d0f.tar.gz slx-admin-cd55ead3e2810e209b726faca12fa749f6875d0f.tar.xz slx-admin-cd55ead3e2810e209b726faca12fa749f6875d0f.zip | |
Fix A LOT of type problems, logic flaws, uninitialized variables etc.
Most of them were found by phpstorm, so I put in some time and
went through the list, fixing quite a bunch of them.
Diffstat (limited to 'modules-available/baseconfig/page.inc.php')
| -rw-r--r-- | modules-available/baseconfig/page.inc.php | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/modules-available/baseconfig/page.inc.php b/modules-available/baseconfig/page.inc.php index 366a1238..426d3fdd 100644 --- a/modules-available/baseconfig/page.inc.php +++ b/modules-available/baseconfig/page.inc.php @@ -30,11 +30,14 @@ class Page_BaseConfig extends Page $qry_values = ', :enabled'; $qry_update = ', enabled = :enabled'; $params = array(); + $delExtra = ''; } elseif (empty($this->qry_extra['field'])) { // Module specific, but module doesn't have an extra field $qry_insert = ''; $qry_values = ''; $qry_update = ''; + $params = array(); + $delExtra = ''; } else { // Module with extra field $qry_insert = ', ' . $this->qry_extra['field']; @@ -290,7 +293,7 @@ class Page_BaseConfig extends Page /** * Create html snippet for setting, based on given validator - * @param type $validator + * @param string $validator * @return boolean */ private function makeInput($validator, $setting, $current, $shadows) |