1 files changed, 30 insertions, 10 deletions

diff --git a/modules-available/statistics/inc/hardwarequery.inc.php b/modules-available/statistics/inc/hardwarequery.inc.php
index 7ccde2f6..b0b7d6ee 100644
--- a/modules-available/statistics/inc/hardwarequery.inc.php
+++ b/modules-available/statistics/inc/hardwarequery.inc.php
@@ -16,13 +16,15 @@ class HardwareQuery
 	public function __construct($type, $uuid = null, $connectedOnly = true)
 	{
 		if ($connectedOnly) {
-			$this->where[] = 'mxhw.disconnecttime = 0';
+			$this->joins['mxhw_join'] = "INNER JOIN machine_x_hw mxhw ON (mxhw.hwid = shw.hwid AND mxhw.disconnecttime = 0)";
+		} else {
+			$this->joins['mxhw_join'] = "INNER JOIN machine_x_hw mxhw ON (mxhw.hwid = shw.hwid)";
 		}
 		if ($uuid !== null) {
 			$this->where[] = 'mxhw.machineuuid = :uuid';
 			$this->args['uuid'] = $uuid;
 		}
-		$this->joins[] = "INNER JOIN statistic_hw shw ON (mxhw.hwid = shw.hwid AND shw.hwtype = :hwtype)";
+		$this->where[] = 'shw.hwtype = :hwtype';
 		$this->args['hwtype'] = $type;
 	}
 
@@ -44,7 +46,13 @@ class HardwareQuery
 		}
 	}
 
-	public function addWhere(bool $global, string $prop, string $op, string $value)
+	/**
+	 * @param bool $global
+	 * @param string $prop
+	 * @param string $op
+	 * @param string|string[] $value
+	 */
+	public function addWhere(bool $global, string $prop, string $op, $value)
 	{
 		if (isset($this->columns[$prop]))
 			return;
@@ -54,7 +62,7 @@ class HardwareQuery
 		$vid = $this->id();
 		$valueCol = ($op === '<' || $op === '>' || $op === '<=' || $op === '>=') ? 'numeric' : 'value';
 		$this->joins[$prop] = "INNER JOIN $table $tid ON ($srcTable.$column = $tid.$column AND
-			$tid.prop = :$pid AND $tid.`$valueCol` $op :$vid)";
+			$tid.prop = :$pid AND $tid.`$valueCol` $op (:$vid))";
 		$this->args[$pid] = $prop;
 		$this->args[$vid] = $value;
 		$this->columns[$prop] = "$tid.`value` AS `$prop`";
@@ -85,7 +93,7 @@ class HardwareQuery
 		$this->fillTableVars($global, $srcTable, $table, $column);
 		$tid = $this->id();
 		$pid = $this->id();
-		$this->joins[$prop] = "INNER JOIN $table $tid ON ($srcTable.$column = $tid.$column AND $tid.prop = :$pid)";
+		$this->joins[$prop] = "LEFT JOIN $table $tid ON ($srcTable.$column = $tid.$column AND $tid.prop = :$pid)";
 		$this->args[$pid] = $prop;
 		$this->columns[$prop] = "$tid.`value` AS `$prop`";
 	}
@@ -93,13 +101,25 @@ class HardwareQuery
 	/**
 	 * @return false|PDOStatement
 	 */
-	public function query()
+	public function query(string $groupBy = '')
 	{
-		$this->columns[] = 'mxhw.machineuuid';
-		$query = 'SELECT ' . implode(', ', $this->columns)
-			. ' FROM machine_x_hw mxhw '
+		$columns = $this->columns;
+		$columns[] = 'mxhw.machineuuid';
+		$columns[] = 'shw.hwid';
+		if (empty($groupBy) || $groupBy === 'mxhw.machinehwid') {
+			$columns[] = 'mxhw.disconnecttime';
+		} else {
+			$columns[] = 'Sum(If(mxhw.disconnecttime = 0, 1, 0)) AS connected_count';
+		}
+		if (!empty($groupBy)) {
+			$columns[] = 'Count(*) AS group_count';
+			$groupBy = " GROUP BY $groupBy";
+		}
+		$query = 'SELECT ' . implode(', ', $columns)
+			. ' FROM statistic_hw shw '
 			. implode(' ', $this->joins)
-			. ' WHERE ' . implode(' AND ', $this->where);
+			. ' WHERE ' . implode(' AND ', $this->where)
+			. $groupBy;
 		return Database::simpleQuery($query, $this->args);
 	}