[clone_stage4] Throw error if wrong number of arguments is given, instead of trying broken backwards compatibility mode

1 files changed, 10 insertions, 10 deletions

diff --git a/scripts/clone_stage4 b/scripts/clone_stage4
index 8804a57a..4c430aa8 100755
--- a/scripts/clone_stage4
+++ b/scripts/clone_stage4
@@ -15,14 +15,14 @@ MLTK_PID="$$"
 qnd_exit() {
 	unset_quiet
 	kill "$MLTK_PID"
-	[ $# -ge 1 ] && kill "$1"
+	[ $# -ge 1 ] && kill "$REMOTE_HOST"
 }
 
-[ $# -lt 2 ] && perror "$0 <remote_ip> <target_dir>"
-[ "$1" = "local" ] && perror 'It is not wise to use "local" as remote IP.'
+[ $# -ne 2 ] && perror "$0 <remote_ip> <target_dir> (-- Hint: <stage_to_exclude> is gone now, only two parameters are needed)"
+[ "$REMOTE_HOST" = "local" ] && perror 'It is not wise to use "local" as remote IP.'
 
-BOOT_DIR="${ROOT_DIR}/server/boot/$1"
-[ $# -eq 3 ] && shift # compat with old calling convention "$0 <remote_ip> <stage_to_exclude> <target_dir>"
+REMOTE_HOST="$1"
+BOOT_DIR="${ROOT_DIR}/server/boot/$REMOTE_HOST"
 TARGET_DIR="$2"
 mkdir -p "$TARGET_DIR"
 mkdir -p "$BOOT_DIR"
@@ -31,8 +31,8 @@ EXCLUDE="$BOOT_DIR/exclude-stage4"
 INCLUDE="$BOOT_DIR/include-stage4"
 
 pinfo "Building rsync exclude-file for building stage 4...."
-echo "## Exclude file for stage4 of $1" > "$EXCLUDE"
-echo "## Include file for stage4 of $1" > "$INCLUDE"
+echo "## Exclude file for stage4 of $REMOTE_HOST" > "$EXCLUDE"
+echo "## Include file for stage4 of $REMOTE_HOST" > "$INCLUDE"
 for FILE in $(find "$ROOT_DIR"/server/blacklists/*/ -type f); do
 	echo "## From $FILE" >> "$EXCLUDE"
 	echo "## From $FILE" >> "$INCLUDE"
@@ -46,11 +46,11 @@ pinfo "Done."
 # prepare rsync's options depending on whether the source is local or remote
 RSYNC_OPTS=""
 RSYNC_SOURCE=""
-if [[ "$1" == "local" ]]; then
+if [[ "$REMOTE_HOST" == "local" ]]; then
 	RSYNC_SOURCE="/"
 else
-	RSYNC_SOURCE="root@$1:/"
-	RSYNC_OPTS="-e ssh -oStrictHostKeyChecking=no"
+	RSYNC_SOURCE="root@$REMOTE_HOST:/"
+	RSYNC_OPTS="-e ssh -c arcfour -oStrictHostKeyChecking=no"
 fi
 
 pinfo "Cloning via rsync"