summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJonathan Bauer2018-04-16 17:45:59 +0200
committerJonathan Bauer2018-04-16 17:45:59 +0200
commit4dbc9d8668df4fc0c4ff10b3f642c63949bd0ab7 (patch)
tree9594a98ffad80ee70287e0345dd9f71e2b7d2fd5
parent[client] Minor cleanups, add/remove TODOs, rename vars, ... (diff)
downloadtutor-module-4dbc9d8668df4fc0c4ff10b3f642c63949bd0ab7.tar.gz
tutor-module-4dbc9d8668df4fc0c4ff10b3f642c63949bd0ab7.tar.xz
tutor-module-4dbc9d8668df4fc0c4ff10b3f642c63949bd0ab7.zip
[client] add error message for humans
to stock printStackTraces()
-rwxr-xr-xdozentenmodul/src/main/java/org/openslx/dozmod/App.java4
-rw-r--r--dozentenmodul/src/main/java/org/openslx/dozmod/gui/window/VirtConfigEditorWindow.java2
-rw-r--r--dozentenmodul/src/main/java/org/openslx/dozmod/gui/window/VirtDropDownConfigEditorWindow.java7
3 files changed, 8 insertions, 5 deletions
diff --git a/dozentenmodul/src/main/java/org/openslx/dozmod/App.java b/dozentenmodul/src/main/java/org/openslx/dozmod/App.java
index e326cce3..8e971eaa 100755
--- a/dozentenmodul/src/main/java/org/openslx/dozmod/App.java
+++ b/dozentenmodul/src/main/java/org/openslx/dozmod/App.java
@@ -81,7 +81,7 @@ public class App {
fa.setEncoding("UTF-8");
// All classes should log to file, configure global file appender.
} catch (IOException e) {
- e.printStackTrace();
+ LOGGER.error("Failed to set logfile path to '" + logFilePath + "': ", e);
BasicConfigurator.configure();
return;
}
@@ -260,7 +260,7 @@ public class App {
try {
ClientVersion.createJson(destination);
} catch (IOException e) {
- e.printStackTrace();
+ LOGGER.error("Failed to write JSON update file to '" + destination + "': ", e);
}
}
diff --git a/dozentenmodul/src/main/java/org/openslx/dozmod/gui/window/VirtConfigEditorWindow.java b/dozentenmodul/src/main/java/org/openslx/dozmod/gui/window/VirtConfigEditorWindow.java
index 349bf9b1..5d354fad 100644
--- a/dozentenmodul/src/main/java/org/openslx/dozmod/gui/window/VirtConfigEditorWindow.java
+++ b/dozentenmodul/src/main/java/org/openslx/dozmod/gui/window/VirtConfigEditorWindow.java
@@ -91,7 +91,7 @@ public class VirtConfigEditorWindow extends VirtConfigEditorWindowLayout impleme
metaCandidate = VmMetaData.getInstance(MetaDataCache.getOperatingSystems(), uiBytes,
uiBytes.length);
} catch (IOException e) {
- e.printStackTrace();
+ LOGGER.error("Could not get VmMetaData instance from given machine description: ", e);
}
if ( metaCandidate == null ) {
dispose();
diff --git a/dozentenmodul/src/main/java/org/openslx/dozmod/gui/window/VirtDropDownConfigEditorWindow.java b/dozentenmodul/src/main/java/org/openslx/dozmod/gui/window/VirtDropDownConfigEditorWindow.java
index c151f505..764630cc 100644
--- a/dozentenmodul/src/main/java/org/openslx/dozmod/gui/window/VirtDropDownConfigEditorWindow.java
+++ b/dozentenmodul/src/main/java/org/openslx/dozmod/gui/window/VirtDropDownConfigEditorWindow.java
@@ -6,6 +6,7 @@ import java.awt.event.ActionListener;
import java.io.IOException;
import java.nio.ByteBuffer;
+import org.apache.log4j.Logger;
import org.openslx.dozmod.gui.Gui;
import org.openslx.dozmod.gui.helper.MessageType;
import org.openslx.dozmod.gui.helper.UiFeedback;
@@ -24,6 +25,8 @@ import org.openslx.util.vm.VmMetaData.SoundCardType;
public class VirtDropDownConfigEditorWindow extends VirtDropDownConfigEditorWindowLayout implements
UiFeedback {
+ private final static Logger LOGGER = Logger.getLogger(VirtDropDownConfigEditorWindow.class);
+
public interface VirtConfigChanged {
public void virtConfigChanged(String newVmx);
}
@@ -47,8 +50,8 @@ public class VirtDropDownConfigEditorWindow extends VirtDropDownConfigEditorWind
try {
metaCandidate = VmMetaData.getInstance(MetaDataCache.getOperatingSystems(), machineData,
machineData.length);
- } catch (IOException e1) {
- e1.printStackTrace();
+ } catch (IOException e) {
+ LOGGER.error("Could not get VmMetaData instance from given machine description: ", e);
}
if (metaCandidate == null) {
dispose();