summaryrefslogtreecommitdiffstats
path: root/config-db
diff options
context:
space:
mode:
authorOliver Tappe2006-12-11 20:49:55 +0100
committerOliver Tappe2006-12-11 20:49:55 +0100
commitcd19e08af1e32f61f33701cfe9590ec81d785124 (patch)
treee806dad28547f766878d4e52c1ca32564c24b8eb /config-db
parentbigfix in DBSchema, floppy image renamed to fd.img (diff)
downloadcore-cd19e08af1e32f61f33701cfe9590ec81d785124.tar.gz
core-cd19e08af1e32f61f33701cfe9590ec81d785124.tar.xz
core-cd19e08af1e32f61f33701cfe9590ec81d785124.zip
* fixed several missing return statements
git-svn-id: http://svn.openslx.org/svn/openslx/trunk@529 95ad53e4-c205-0410-b2fa-d234c58c8868
Diffstat (limited to 'config-db')
-rw-r--r--config-db/OpenSLX/MetaDB/DBI.pm12
1 files changed, 7 insertions, 5 deletions
diff --git a/config-db/OpenSLX/MetaDB/DBI.pm b/config-db/OpenSLX/MetaDB/DBI.pm
index 0159a03b..ad4c12b5 100644
--- a/config-db/OpenSLX/MetaDB/DBI.pm
+++ b/config-db/OpenSLX/MetaDB/DBI.pm
@@ -422,7 +422,7 @@ sub _doUpdate
map { "$_ = ".$self->quote($valRow->{$_}) }
grep { $_ ne 'id' }
# filter column 'id' if present, as we don't want
- # to update it
+ # to update it!
keys %$valRow;
my $sql = "UPDATE $table SET $cols";
if (defined $id) {
@@ -469,6 +469,7 @@ sub _updateRefTable
if (scalar keys %lastValueIDs) {
$self->_doDelete($table, [ keys %lastValueIDs ], $valueCol);
}
+ return 1;
}
sub _updateOneToManyRefAttr
@@ -497,6 +498,7 @@ sub _updateOneToManyRefAttr
foreach my $id (scalar keys %lastManyIDs) {
$self->_doUpdate($table, $id, [{ $fkCol => '0' }]);
}
+ return 1;
}
sub addVendorOS
@@ -556,8 +558,8 @@ sub setClientIDsOfSystem
my $clientIDs = shift;
my @currClients = $self->fetchClientIDsOfSystem($systemID);
- $self->_updateRefTable('client_system_ref', $systemID, $clientIDs,
- 'system_id', 'client_id', \@currClients);
+ return $self->_updateRefTable('client_system_ref', $systemID, $clientIDs,
+ 'system_id', 'client_id', \@currClients);
}
sub setGroupIDsOfSystem
@@ -567,8 +569,8 @@ sub setGroupIDsOfSystem
my $groupIDs = shift;
my @currGroups = $self->fetchGroupIDsOfSystem($systemID);
- $self->_updateRefTable('group_system_ref', $systemID, $groupIDs,
- 'system_id', 'group_id', \@currGroups);
+ return $self->_updateRefTable('group_system_ref', $systemID, $groupIDs,
+ 'system_id', 'group_id', \@currGroups);
}
sub addSystemVariant