* activated 'use warnings' to all modules and adjusted all occurences of

  'use of uninitialized values', a couple of which might still show up
* adjusted all code with respect to passing perlcritic level 4 and 5

git-svn-id: http://svn.openslx.org/svn/openslx/trunk@1207 95ad53e4-c205-0410-b2fa-d234c58c8868

7 files changed, 23 insertions, 36 deletions

diff --git a/installer/OpenSLX/OSExport/Distro/Any.pm b/installer/OpenSLX/OSExport/Distro/Any.pm
index 828e4990..976bbadf 100644
--- a/installer/OpenSLX/OSExport/Distro/Any.pm
+++ b/installer/OpenSLX/OSExport/Distro/Any.pm
@@ -13,14 +13,12 @@
 # -----------------------------------------------------------------------------
 package OpenSLX::OSExport::Distro::Any;
 
-use vars qw($VERSION);
+use strict;
+use warnings;
+
 use base qw(OpenSLX::OSExport::Distro::Base);
-$VERSION = 1.01;		# API-version . implementation-version
 
-use strict;
-use Carp;
 use OpenSLX::Basics;
-use OpenSLX::OSExport::Distro::Base 1;
 
 ################################################################################
 ### implementation
diff --git a/installer/OpenSLX/OSExport/Distro/Base.pm b/installer/OpenSLX/OSExport/Distro/Base.pm
index 645523c6..f1986ee5 100644
--- a/installer/OpenSLX/OSExport/Distro/Base.pm
+++ b/installer/OpenSLX/OSExport/Distro/Base.pm
@@ -14,13 +14,12 @@
 # -----------------------------------------------------------------------------
 package OpenSLX::OSExport::Distro::Base;
 
-use vars qw($VERSION);
-$VERSION = 1.01;		# API-version . implementation-version
-
 use strict;
-use Carp;
-use File::Basename;
-use OpenSLX::Basics;
+use warnings;
+
+our $VERSION = 1.01;		# API-version . implementation-version
+
+use Carp qw(confess);
 
 ################################################################################
 ### interface methods
diff --git a/installer/OpenSLX/OSExport/Distro/Debian.pm b/installer/OpenSLX/OSExport/Distro/Debian.pm
index 35e7f4c9..5f161902 100644
--- a/installer/OpenSLX/OSExport/Distro/Debian.pm
+++ b/installer/OpenSLX/OSExport/Distro/Debian.pm
@@ -13,14 +13,12 @@
 # -----------------------------------------------------------------------------
 package OpenSLX::OSExport::Distro::Debian;
 
-use vars qw($VERSION);
+use strict;
+use warnings;
+
 use base qw(OpenSLX::OSExport::Distro::Base);
-$VERSION = 1.01;		# API-version . implementation-version
 
-use strict;
-use Carp;
 use OpenSLX::Basics;
-use OpenSLX::OSExport::Distro::Base 1;
 
 ################################################################################
 ### implementation
diff --git a/installer/OpenSLX/OSExport/Distro/Fedora.pm b/installer/OpenSLX/OSExport/Distro/Fedora.pm
index 9374678d..0ef3e028 100644
--- a/installer/OpenSLX/OSExport/Distro/Fedora.pm
+++ b/installer/OpenSLX/OSExport/Distro/Fedora.pm
@@ -13,14 +13,12 @@
 # -----------------------------------------------------------------------------
 package OpenSLX::OSExport::Distro::Fedora;
 
-use vars qw($VERSION);
+use strict;
+use warnings;
+
 use base qw(OpenSLX::OSExport::Distro::Base);
-$VERSION = 1.01;		# API-version . implementation-version
 
-use strict;
-use Carp;
 use OpenSLX::Basics;
-use OpenSLX::OSExport::Distro::Base 1;
 
 ################################################################################
 ### implementation
diff --git a/installer/OpenSLX/OSExport/Distro/Gentoo.pm b/installer/OpenSLX/OSExport/Distro/Gentoo.pm
index c7d4575f..4d908650 100644
--- a/installer/OpenSLX/OSExport/Distro/Gentoo.pm
+++ b/installer/OpenSLX/OSExport/Distro/Gentoo.pm
@@ -13,14 +13,12 @@
 # -----------------------------------------------------------------------------
 package OpenSLX::OSExport::Distro::Gentoo;
 
-use vars qw($VERSION);
+use strict;
+use warnings;
+
 use base qw(OpenSLX::OSExport::Distro::Base);
-$VERSION = 1.01;		# API-version . implementation-version
 
-use strict;
-use Carp;
 use OpenSLX::Basics;
-use OpenSLX::OSExport::Distro::Base 1;
 
 ################################################################################
 ### implementation
diff --git a/installer/OpenSLX/OSExport/Distro/SUSE.pm b/installer/OpenSLX/OSExport/Distro/SUSE.pm
index 7da7656b..1f826159 100644
--- a/installer/OpenSLX/OSExport/Distro/SUSE.pm
+++ b/installer/OpenSLX/OSExport/Distro/SUSE.pm
@@ -13,14 +13,12 @@
 # -----------------------------------------------------------------------------
 package OpenSLX::OSExport::Distro::SUSE;
 
-use vars qw($VERSION);
+use strict;
+use warnings;
+
 use base qw(OpenSLX::OSExport::Distro::Base);
-$VERSION = 1.01;		# API-version . implementation-version
 
-use strict;
-use Carp;
 use OpenSLX::Basics;
-use OpenSLX::OSExport::Distro::Base 1;
 
 ################################################################################
 ### implementation
diff --git a/installer/OpenSLX/OSExport/Distro/Ubuntu.pm b/installer/OpenSLX/OSExport/Distro/Ubuntu.pm
index 409bb0cf..8dbaae9e 100644
--- a/installer/OpenSLX/OSExport/Distro/Ubuntu.pm
+++ b/installer/OpenSLX/OSExport/Distro/Ubuntu.pm
@@ -13,14 +13,12 @@
 # -----------------------------------------------------------------------------
 package OpenSLX::OSExport::Distro::Ubuntu;
 
-use vars qw($VERSION);
+use strict;
+use warnings;
+
 use base qw(OpenSLX::OSExport::Distro::Base);
-$VERSION = 1.01;		# API-version . implementation-version
 
-use strict;
-use Carp;
 use OpenSLX::Basics;
-use OpenSLX::OSExport::Distro::Base 1;
 
 ################################################################################
 ### implementation