* activated 'use warnings' to all modules and adjusted all occurences of

  'use of uninitialized values', a couple of which might still show up
* adjusted all code with respect to passing perlcritic level 4 and 5

git-svn-id: http://svn.openslx.org/svn/openslx/trunk@1207 95ad53e4-c205-0410-b2fa-d234c58c8868

1 files changed, 9 insertions, 6 deletions

diff --git a/installer/slxos-export b/installer/slxos-export
index 19ec3d5b..bdebd9f3 100755
--- a/installer/slxos-export
+++ b/installer/slxos-export
@@ -11,6 +11,7 @@
 # General information about OpenSLX can be found at http://openslx.org/
 # -----------------------------------------------------------------------------
 use strict;
+use warnings;
 
 my $abstract = q[
 slxos-export
@@ -61,9 +62,10 @@ if ($action =~ m[^list-ex]i) {
 	print _tr("List of exported vendor-OSes:\n");
 	foreach my $type (sort keys %supportedExportFileSystems) {
 		# list all image files, followed by the block devices using it:
-		my @files = map {    
-			s[^.+/][];
-			$_
+		my @files = map {
+			my $image = $_;
+			$image =~ s[^.+/][];
+			$image;
 		} sort <$openslxConfig{'public-path'}/export/$type/*>;
 		my %imageFiles;
 		foreach my $file (@files) {
@@ -95,13 +97,14 @@ if ($action =~ m[^list-ex]i) {
 		);
 	}
 } elsif ($action =~ m[^list-in]i) {
-	my @files = <$openslxConfig{'private-path'}/stage1/*>;
+	my @files = glob("$openslxConfig{'private-path'}/stage1/*");
 	print _tr("List of installed vendor-OSes:\n");
 	print join(
 		'',
 		map {
-			s[^.+/][];
-			"\t$_\n";
+			my $vendorOS = $_;
+			$vendorOS =~ s[^.+/][];
+			"\t$vendorOS\n";
 		  }
 		  sort @files
 	);