diff options
| author | Gustavo A. R. Silva | 2019-02-21 03:06:33 +0100 |
|---|---|---|
| committer | Jonathan Cameron | 2019-04-04 21:19:50 +0200 |
| commit | 74c420e0a581c2e333c2f5742506e86f198af70b (patch) | |
| tree | 56ef2d64d230a7f91c58bc087684e739f55c5224 /.mailmap | |
| parent | iio: st_accel: remove redundant unsigned less than zero check (diff) | |
| download | kernel-qcow2-linux-74c420e0a581c2e333c2f5742506e86f198af70b.tar.gz kernel-qcow2-linux-74c420e0a581c2e333c2f5742506e86f198af70b.tar.xz kernel-qcow2-linux-74c420e0a581c2e333c2f5742506e86f198af70b.zip | |
iio: cros_ec_accel_legacy: Refactor code in cros_ec_accel_legacy_probe
Refactor some code in order to fix both the technical implementation
and the following warnings:
drivers/iio/accel/cros_ec_accel_legacy.c: In function ‘cros_ec_accel_legacy_probe’:
drivers/iio/accel/cros_ec_accel_legacy.c:387:36: warning: this statement may fall through [-Wimplicit-fallthrough=]
ec_accel_channels[X].scan_index = Y;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/iio/accel/cros_ec_accel_legacy.c:388:3: note: here
case Y:
^~~~
drivers/iio/accel/cros_ec_accel_legacy.c:389:36: warning: this statement may fall through [-Wimplicit-fallthrough=]
ec_accel_channels[Y].scan_index = X;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/iio/accel/cros_ec_accel_legacy.c:390:3: note: here
case Z:
^~~~
Notice that neither the for loop nor the switch statement is needed.
Also, "state->sign[Y] = 1" should be unconditional.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Kees Cook <keescook@chromium.org>
Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to '.mailmap')
0 files changed, 0 insertions, 0 deletions