summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
author=?utf-8?q?Michel_D=C3=A4nzer?=2006-10-24 15:34:58 +0200
committerairlied2006-12-07 05:53:29 +0100
commit049b323321bbcb476b799f50dc6444c0ed5a0e0e (patch)
tree86c57b038dcb7a6de4b6a7af8c276550d6b9524b
parentdrm: Core vsync: Add flag DRM_VBLANK_NEXTONMISS. (diff)
downloadkernel-qcow2-linux-049b323321bbcb476b799f50dc6444c0ed5a0e0e.tar.gz
kernel-qcow2-linux-049b323321bbcb476b799f50dc6444c0ed5a0e0e.tar.xz
kernel-qcow2-linux-049b323321bbcb476b799f50dc6444c0ed5a0e0e.zip
drm: Core vsync: Don't clobber target sequence number when scheduling signal.
It looks like this would have caused signals to always get sent on the next vertical blank, regardless of the sequence number. Signed-off-by: Dave Airlie <airlied@linux.ie>
-rw-r--r--drivers/char/drm/drm_irq.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/char/drm/drm_irq.c b/drivers/char/drm/drm_irq.c
index 78aae5b35c62..9d00c51fe2c4 100644
--- a/drivers/char/drm/drm_irq.c
+++ b/drivers/char/drm/drm_irq.c
@@ -296,8 +296,6 @@ int drm_wait_vblank(DRM_IOCTL_ARGS)
? &dev->vbl_sigs2 : &dev->vbl_sigs;
drm_vbl_sig_t *vbl_sig;
- vblwait.reply.sequence = seq;
-
spin_lock_irqsave(&dev->vbl_lock, irqflags);
/* Check if this task has already scheduled the same signal
@@ -310,6 +308,7 @@ int drm_wait_vblank(DRM_IOCTL_ARGS)
&& vbl_sig->task == current) {
spin_unlock_irqrestore(&dev->vbl_lock,
irqflags);
+ vblwait.reply.sequence = seq;
goto done;
}
}
@@ -340,6 +339,8 @@ int drm_wait_vblank(DRM_IOCTL_ARGS)
list_add_tail((struct list_head *)vbl_sig, &vbl_sigs->head);
spin_unlock_irqrestore(&dev->vbl_lock, irqflags);
+
+ vblwait.reply.sequence = seq;
} else {
if (flags & _DRM_VBLANK_SECONDARY) {
if (dev->driver->vblank_wait2)