diff options
| author | Alan | 2016-02-15 20:11:56 +0100 |
|---|---|---|
| committer | Martin K. Petersen | 2016-02-24 03:27:02 +0100 |
| commit | 0872774d8a319676dea7416e0cf85bec63eea0d0 (patch) | |
| tree | dea7ecd09b06f5de85a592bb0a90e0fcf235c000 | |
| parent | esas2r: Fix array overrun (diff) | |
| download | kernel-qcow2-linux-0872774d8a319676dea7416e0cf85bec63eea0d0.tar.gz kernel-qcow2-linux-0872774d8a319676dea7416e0cf85bec63eea0d0.tar.xz kernel-qcow2-linux-0872774d8a319676dea7416e0cf85bec63eea0d0.zip | |
lpfc: fix missing zero termination in debugfs
If you feed 32 bytes in then the kstrtoull() doesn't receive a terminated
string so will run off the end.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| -rw-r--r-- | drivers/scsi/lpfc/lpfc_debugfs.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c index 25aa9b98d53a..a63542bac153 100644 --- a/drivers/scsi/lpfc/lpfc_debugfs.c +++ b/drivers/scsi/lpfc/lpfc_debugfs.c @@ -1054,11 +1054,11 @@ lpfc_debugfs_dif_err_write(struct file *file, const char __user *buf, { struct dentry *dent = file->f_path.dentry; struct lpfc_hba *phba = file->private_data; - char dstbuf[32]; + char dstbuf[33]; uint64_t tmp = 0; int size; - memset(dstbuf, 0, 32); + memset(dstbuf, 0, 33); size = (nbytes < 32) ? nbytes : 32; if (copy_from_user(dstbuf, buf, size)) return 0; |