summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHiroaki SHIMODA2012-05-30 14:24:39 +0200
committerDavid S. Miller2012-06-01 00:18:16 +0200
commit0cfd32b736ae0c36b42697584811042726c07cba (patch)
tree1e667905d1a668206875db4dc5eeb6d72a7c299d
parentnet/mlx4_core: Fix obscure mlx4_cmd_box parameter in QUERY_DEV_CAP (diff)
downloadkernel-qcow2-linux-0cfd32b736ae0c36b42697584811042726c07cba.tar.gz
kernel-qcow2-linux-0cfd32b736ae0c36b42697584811042726c07cba.tar.xz
kernel-qcow2-linux-0cfd32b736ae0c36b42697584811042726c07cba.zip
bql: Fix POSDIFF() to integer overflow aware.
POSDIFF() fails to take into account integer overflow case. Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com> Cc: Tom Herbert <therbert@google.com> Cc: Eric Dumazet <eric.dumazet@gmail.com> Cc: Denys Fedoryshchenko <denys@visp.net.lb> Acked-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--lib/dynamic_queue_limits.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/dynamic_queue_limits.c b/lib/dynamic_queue_limits.c
index 6ab4587d052b..c87eb76f2fd4 100644
--- a/lib/dynamic_queue_limits.c
+++ b/lib/dynamic_queue_limits.c
@@ -10,7 +10,7 @@
#include <linux/jiffies.h>
#include <linux/dynamic_queue_limits.h>
-#define POSDIFF(A, B) ((A) > (B) ? (A) - (B) : 0)
+#define POSDIFF(A, B) ((int)((A) - (B)) > 0 ? (A) - (B) : 0)
/* Records completed count and recalculates the queue limit */
void dql_completed(struct dql *dql, unsigned int count)