diff options
| author | Dan Carpenter | 2019-06-13 08:51:02 +0200 |
|---|---|---|
| committer | David S. Miller | 2019-06-15 04:21:31 +0200 |
| commit | 1086ca3a63a3af6b8a722fff55da46f111bc40ee (patch) | |
| tree | 61d409950eaa4ace161621b97a0b172de4dafe2f | |
| parent | vsock: correct removal of socket from the list (diff) | |
| download | kernel-qcow2-linux-1086ca3a63a3af6b8a722fff55da46f111bc40ee.tar.gz kernel-qcow2-linux-1086ca3a63a3af6b8a722fff55da46f111bc40ee.tar.xz kernel-qcow2-linux-1086ca3a63a3af6b8a722fff55da46f111bc40ee.zip | |
net: phy: sfp: clean up a condition
The acpi_node_get_property_reference() doesn't return ACPI error codes,
it just returns regular negative kernel error codes. This patch doesn't
affect run time, it's just a clean up.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ruslan Babayev <ruslan@babayev.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/phy/sfp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 97960d73b4ab..2d816aadea79 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -1848,7 +1848,7 @@ static int sfp_probe(struct platform_device *pdev) int ret; ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args); - if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) { + if (ret || !is_acpi_device_node(args.fwnode)) { dev_err(&pdev->dev, "missing 'i2c-bus' property\n"); return -ENODEV; } |