summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorguneshwor.o.singh@intel.com2017-07-28 12:42:16 +0200
committerMark Brown2017-08-01 14:34:09 +0200
commit10a5439f0e4db0b1c4c2a2f6c916d6501cfeae50 (patch)
tree0b263c70af557d0b80640260783fb0e05f5791cd
parentASoC: Intel: Skylake: Remove return check for skl_codec_create() (diff)
downloadkernel-qcow2-linux-10a5439f0e4db0b1c4c2a2f6c916d6501cfeae50.tar.gz
kernel-qcow2-linux-10a5439f0e4db0b1c4c2a2f6c916d6501cfeae50.tar.xz
kernel-qcow2-linux-10a5439f0e4db0b1c4c2a2f6c916d6501cfeae50.zip
ASoC: Intel: Skylake: Fix potential null pointer dereference
Check if the next sink is not null to avoid potential null pointer dereference in skl_tplg_bind_sinks(). Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com> Acked-By: Vinod Koul <vinod.koul@intel.com> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--sound/soc/intel/skylake/skl-topology.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index 68c3f121efc3..8c3ce08f366d 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -925,7 +925,7 @@ static int skl_tplg_bind_sinks(struct snd_soc_dapm_widget *w,
}
}
- if (!sink)
+ if (!sink && next_sink)
return skl_tplg_bind_sinks(next_sink, skl, src_w, src_mconfig);
return 0;