summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSebastian Andrzej Siewior2019-06-21 16:36:42 +0200
committerThomas Gleixner2019-06-22 12:14:22 +0200
commit12063d431078be73d11cb5e48a17c6db5f0d8254 (patch)
tree3e687b60a21f6b613752ea0abf908a0a3a1fa13d
parenttimekeeping: Add missing _ns functions for coarse accessors (diff)
downloadkernel-qcow2-linux-12063d431078be73d11cb5e48a17c6db5f0d8254.tar.gz
kernel-qcow2-linux-12063d431078be73d11cb5e48a17c6db5f0d8254.tar.xz
kernel-qcow2-linux-12063d431078be73d11cb5e48a17c6db5f0d8254.zip
posix-timers: Remove "it_signal = NULL" assignment in itimer_delete()
itimer_delete() is invoked during do_exit(). At this point it is the last thread in the group dying and doing the clean up. Since it is the last thread in the group, there can not be any other task attempting to lock the itimer which means the NULL assignment (which avoids lookups in __lock_timer()) is not required. The assignment and comment was copied in commit 0e568881178ff ("[PATCH] fix posix-timers to have proper per-process scope") from sys_timer_delete() which was/is the syscall interface and requires the assignment. Remove the superfluous ->it_signal = NULL assignment. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lkml.kernel.org/r/20190621143643.25649-2-bigeasy@linutronix.de
-rw-r--r--kernel/time/posix-timers.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c
index 29176635991f..caa63e58e3d8 100644
--- a/kernel/time/posix-timers.c
+++ b/kernel/time/posix-timers.c
@@ -990,11 +990,6 @@ retry_delete:
goto retry_delete;
}
list_del(&timer->list);
- /*
- * This keeps any tasks waiting on the spin lock from thinking
- * they got something (see the lock code above).
- */
- timer->it_signal = NULL;
unlock_timer(timer, flags);
release_posix_timer(timer, IT_ID_SET);