summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid S. Miller2017-07-02 00:24:06 +0200
committerDavid S. Miller2017-07-02 00:24:06 +0200
commit15324b25d5792b92c44714e20694a2df3a3a7b8f (patch)
tree90b44e4038c4635425311e2a1fa5fa44556e76b9
parentnet/mlx5: fix spelling mistake: "Allodating" -> "Allocating" (diff)
parentsfc: correct comment on efx_mcdi_process_event (diff)
downloadkernel-qcow2-linux-15324b25d5792b92c44714e20694a2df3a3a7b8f.tar.gz
kernel-qcow2-linux-15324b25d5792b92c44714e20694a2df3a3a7b8f.tar.xz
kernel-qcow2-linux-15324b25d5792b92c44714e20694a2df3a3a7b8f.zip
Merge branch 'sfc-MCDI-cleanups'
Edward Cree says: ==================== sfc: small MCDI cleanups Giving the full MCDI event rather than just the code can aid in debugging. While fixing this I noticed an outdated comment. ==================== Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/sfc/mcdi.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/net/ethernet/sfc/mcdi.c b/drivers/net/ethernet/sfc/mcdi.c
index b9422450deb8..3df872f56289 100644
--- a/drivers/net/ethernet/sfc/mcdi.c
+++ b/drivers/net/ethernet/sfc/mcdi.c
@@ -1301,7 +1301,7 @@ static void efx_mcdi_abandon(struct efx_nic *efx)
efx_schedule_reset(efx, RESET_TYPE_MCDI_TIMEOUT);
}
-/* Called from falcon_process_eventq for MCDI events */
+/* Called from efx_farch_ev_process and efx_ef10_ev_process for MCDI events */
void efx_mcdi_process_event(struct efx_channel *channel,
efx_qword_t *event)
{
@@ -1389,8 +1389,9 @@ void efx_mcdi_process_event(struct efx_channel *channel,
MCDI_EVENT_FIELD(*event, PROXY_RESPONSE_RC));
break;
default:
- netif_err(efx, hw, efx->net_dev, "Unknown MCDI event 0x%x\n",
- code);
+ netif_err(efx, hw, efx->net_dev,
+ "Unknown MCDI event " EFX_QWORD_FMT "\n",
+ EFX_QWORD_VAL(*event));
}
}