diff options
| author | Sagi Grimberg | 2014-03-14 13:51:58 +0100 |
|---|---|---|
| committer | Roland Dreier | 2014-03-24 18:05:30 +0100 |
| commit | 2088ca66f5e986c06dc1deb4e2f004218b652300 (patch) | |
| tree | e9c9fe63b8f926fc28f7b24e33eddfa814dc4045 | |
| parent | scsi_transport_srp: Fix two kernel-doc warnings (diff) | |
| download | kernel-qcow2-linux-2088ca66f5e986c06dc1deb4e2f004218b652300.tar.gz kernel-qcow2-linux-2088ca66f5e986c06dc1deb4e2f004218b652300.tar.xz kernel-qcow2-linux-2088ca66f5e986c06dc1deb4e2f004218b652300.zip | |
IB/srp: Check ib_query_gid return value
Detected by Coverity.
Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Roland Dreier <roland@purestorage.com>
| -rw-r--r-- | drivers/infiniband/ulp/srp/ib_srp.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 529b6bcdca7a..890322637e2e 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -2649,7 +2649,9 @@ static ssize_t srp_create_target(struct device *dev, if (ret) goto err_free_mem; - ib_query_gid(ibdev, host->port, 0, &target->path.sgid); + ret = ib_query_gid(ibdev, host->port, 0, &target->path.sgid); + if (ret) + goto err_free_mem; shost_printk(KERN_DEBUG, target->scsi_host, PFX "new target: id_ext %016llx ioc_guid %016llx pkey %04x " |