summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPrashant Bhole2019-06-20 08:58:15 +0200
committerDaniel Borkmann2019-06-24 15:56:56 +0200
commit20f6239d494b2ec7fcc9930eaab3e736a6a9419e (patch)
tree3f27dfa815127e390de915280f1061ec43c88ba1
parentbpf: fix NULL deref in btf_type_is_resolve_source_only (diff)
downloadkernel-qcow2-linux-20f6239d494b2ec7fcc9930eaab3e736a6a9419e.tar.gz
kernel-qcow2-linux-20f6239d494b2ec7fcc9930eaab3e736a6a9419e.tar.xz
kernel-qcow2-linux-20f6239d494b2ec7fcc9930eaab3e736a6a9419e.zip
samples/bpf: xdp_redirect, correctly get dummy program id
When we terminate xdp_redirect, it ends up with following message: "Program on iface OUT changed, not removing" This results in dummy prog still attached to OUT interface. It is because signal handler checks if the programs are the same that we had attached. But while fetching dummy_prog_id, current code uses prog_fd instead of dummy_prog_fd. This patch passes the correct fd. Fixes: 3b7a8ec2dec3 ("samples/bpf: Check the prog id before exiting") Signed-off-by: Prashant Bhole <prashantbhole.linux@gmail.com> Acked-by: Toke Høiland-Jørgensen <toke@redhat.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
-rw-r--r--samples/bpf/xdp_redirect_user.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/samples/bpf/xdp_redirect_user.c b/samples/bpf/xdp_redirect_user.c
index e9054c0269ff..1299e0f61dad 100644
--- a/samples/bpf/xdp_redirect_user.c
+++ b/samples/bpf/xdp_redirect_user.c
@@ -197,7 +197,7 @@ int main(int argc, char **argv)
}
memset(&info, 0, sizeof(info));
- ret = bpf_obj_get_info_by_fd(prog_fd, &info, &info_len);
+ ret = bpf_obj_get_info_by_fd(dummy_prog_fd, &info, &info_len);
if (ret) {
printf("can't get prog info - %s\n", strerror(errno));
return ret;