diff options
| author | Markus Elfring | 2014-11-21 12:40:32 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2014-11-27 04:35:49 +0100 |
| commit | 48f5cde566201f987125ec783f40dc84b69ce300 (patch) | |
| tree | 6b1215215072440faf8689bfccc93eface0f5b5d | |
| parent | tty: Deletion of unnecessary checks before two function calls (diff) | |
| download | kernel-qcow2-linux-48f5cde566201f987125ec783f40dc84b69ce300.tar.gz kernel-qcow2-linux-48f5cde566201f987125ec783f40dc84b69ce300.tar.xz kernel-qcow2-linux-48f5cde566201f987125ec783f40dc84b69ce300.zip | |
tty-hvsi_lib: Deletion of an unnecessary check before the function call "tty_kref_put"
The tty_kref_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/tty/hvc/hvsi_lib.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/tty/hvc/hvsi_lib.c b/drivers/tty/hvc/hvsi_lib.c index 7ae6c293e518..a270f04588d7 100644 --- a/drivers/tty/hvc/hvsi_lib.c +++ b/drivers/tty/hvc/hvsi_lib.c @@ -405,8 +405,7 @@ void hvsilib_close(struct hvsi_priv *pv, struct hvc_struct *hp) hvsi_send_close(pv); } - if (pv->tty) - tty_kref_put(pv->tty); + tty_kref_put(pv->tty); pv->tty = NULL; } |