summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJacek Anaszewski2016-01-18 17:10:25 +0100
committerMauro Carvalho Chehab2016-01-25 13:28:25 +0100
commit4e63959e3773276cc49b488238bd583c53cf54e8 (patch)
tree1d36c39e0565e935e44024002064cb82bf3964b2
parent[media] exynos4-is: fix a format string bug (diff)
downloadkernel-qcow2-linux-4e63959e3773276cc49b488238bd583c53cf54e8.tar.gz
kernel-qcow2-linux-4e63959e3773276cc49b488238bd583c53cf54e8.tar.xz
kernel-qcow2-linux-4e63959e3773276cc49b488238bd583c53cf54e8.zip
[media] s5k6a3: Fix VIDIOC_SUBDEV_G_FMT ioctl for TRY format
VIDIOC_SUBDEV_G_FMT ioctl should return TRY format previously set with VIDIOC_SUBDEV_S_FMT. Currently it is not the case as only ACTIVE formats are saved in the driver. Since the driver doesn't alter hardware state in the set_fmt op anyway, the op can save the format in both TRY and ACTIVE case. Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
-rw-r--r--drivers/media/i2c/s5k6a3.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/media/i2c/s5k6a3.c b/drivers/media/i2c/s5k6a3.c
index b9e43ffa5085..cbe4711e9b31 100644
--- a/drivers/media/i2c/s5k6a3.c
+++ b/drivers/media/i2c/s5k6a3.c
@@ -144,8 +144,7 @@ static int s5k6a3_set_fmt(struct v4l2_subdev *sd,
mf = __s5k6a3_get_format(sensor, cfg, fmt->pad, fmt->which);
if (mf) {
mutex_lock(&sensor->lock);
- if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE)
- *mf = fmt->format;
+ *mf = fmt->format;
mutex_unlock(&sensor->lock);
}
return 0;