summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJouni Malinen2006-03-20 04:21:48 +0100
committerJohn W. Linville2006-03-23 22:16:58 +0100
commit4f7ecdf0b1b8125fe190247beb0df652829e13cb (patch)
treec003b400680386fce0db3ab4e9bb8034953eb960
parent[PATCH] hostap: Fix unlikely read overrun in CIS parsing (diff)
downloadkernel-qcow2-linux-4f7ecdf0b1b8125fe190247beb0df652829e13cb.tar.gz
kernel-qcow2-linux-4f7ecdf0b1b8125fe190247beb0df652829e13cb.tar.xz
kernel-qcow2-linux-4f7ecdf0b1b8125fe190247beb0df652829e13cb.zip
[PATCH] hostap: Remove dead code (duplicated idx != 0)
The Coverity checker (CID: 58) spotted this duplicated idx != 0 validation for unicast keys in prism2_ioctl_siwencodeext(). Signed-off-by: Jouni Malinen <jkmaline@cc.hut.fi> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--drivers/net/wireless/hostap/hostap_ioctl.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/wireless/hostap/hostap_ioctl.c b/drivers/net/wireless/hostap/hostap_ioctl.c
index f3e0ce1ee037..8b37e824dfcb 100644
--- a/drivers/net/wireless/hostap/hostap_ioctl.c
+++ b/drivers/net/wireless/hostap/hostap_ioctl.c
@@ -3358,10 +3358,6 @@ static int prism2_ioctl_siwencodeext(struct net_device *dev,
if (ext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY) {
if (!sta_ptr)
local->tx_keyidx = i;
- else if (i) {
- ret = -EINVAL;
- goto done;
- }
}