summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJaroslav Kysela2007-04-10 22:26:48 +0200
committerDavid S. Miller2007-04-10 22:26:48 +0200
commit50c9cc2e540aeaab78ab548a8d42568977c6844f (patch)
treeb00c30333f5d124a14e371f4bcf5a69051a2df33
parent[TCP]: slow_start_after_idle should influence cwnd validation too (diff)
downloadkernel-qcow2-linux-50c9cc2e540aeaab78ab548a8d42568977c6844f.tar.gz
kernel-qcow2-linux-50c9cc2e540aeaab78ab548a8d42568977c6844f.tar.xz
kernel-qcow2-linux-50c9cc2e540aeaab78ab548a8d42568977c6844f.zip
[NETFILTER]: ipt_CLUSTERIP: fix oops in checkentry function
The clusterip_config_find_get() already increases entries reference counter, so there is no reason to do it twice in checkentry() callback. This causes the config to be freed before it is removed from the list, resulting in a crash when adding the next rule. Signed-off-by: Jaroslav Kysela <perex@suse.cz> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv4/netfilter/ipt_CLUSTERIP.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c b/net/ipv4/netfilter/ipt_CLUSTERIP.c
index e965b333c997..42b08029e867 100644
--- a/net/ipv4/netfilter/ipt_CLUSTERIP.c
+++ b/net/ipv4/netfilter/ipt_CLUSTERIP.c
@@ -411,12 +411,10 @@ checkentry(const char *tablename,
"has invalid config pointer!\n");
return 0;
}
- clusterip_config_entry_get(cipinfo->config);
} else {
/* Case B: This is a new rule referring to an existing
* clusterip config. */
cipinfo->config = config;
- clusterip_config_entry_get(cipinfo->config);
}
} else {
/* Case C: This is a completely new clusterip config */