diff options
| author | Linus Walleij | 2017-03-28 10:40:29 +0200 |
|---|---|---|
| committer | Ulf Hansson | 2017-04-24 21:42:06 +0200 |
| commit | 5744d50d2d9e7efdae4b5d13cd71f49256ada6ba (patch) | |
| tree | 7fa89eb791eb78fd95e2b4e288eba8f2f9f155ca | |
| parent | mmc: core: Factor out mrq preparation from mmc_start_request() (diff) | |
| download | kernel-qcow2-linux-5744d50d2d9e7efdae4b5d13cd71f49256ada6ba.tar.gz kernel-qcow2-linux-5744d50d2d9e7efdae4b5d13cd71f49256ada6ba.tar.xz kernel-qcow2-linux-5744d50d2d9e7efdae4b5d13cd71f49256ada6ba.zip | |
mmc: core: move some code in mmc_start_areq()
"previous" is a better name for the variable storing the previous
asynchronous request, better than the opaque name "data" atleast.
We see that we assign the return status to the returned variable
on all code paths, so we might as well just do that immediately
after calling mmc_finalize_areq().
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
| -rw-r--r-- | drivers/mmc/core/core.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index ffc263283f54..4c3e23f310f8 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -704,7 +704,7 @@ struct mmc_async_req *mmc_start_areq(struct mmc_host *host, { enum mmc_blk_status status; int start_err = 0; - struct mmc_async_req *data = host->areq; + struct mmc_async_req *previous = host->areq; /* Prepare a new request */ if (areq) @@ -712,13 +712,12 @@ struct mmc_async_req *mmc_start_areq(struct mmc_host *host, /* Finalize previous request */ status = mmc_finalize_areq(host); + if (ret_stat) + *ret_stat = status; /* The previous request is still going on... */ - if (status == MMC_BLK_NEW_REQUEST) { - if (ret_stat) - *ret_stat = status; + if (status == MMC_BLK_NEW_REQUEST) return NULL; - } /* Fine so far, start the new request! */ if (status == MMC_BLK_SUCCESS && areq) @@ -737,9 +736,7 @@ struct mmc_async_req *mmc_start_areq(struct mmc_host *host, else host->areq = areq; - if (ret_stat) - *ret_stat = status; - return data; + return previous; } EXPORT_SYMBOL(mmc_start_areq); |